Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<option selected disabled> should not be removeable #516

Closed
chillu opened this issue Mar 5, 2012 · 2 comments
Closed

<option selected disabled> should not be removeable #516

chillu opened this issue Mar 5, 2012 · 2 comments

Comments

@chillu
Copy link

chillu commented Mar 5, 2012

We're using chosen.js to present some inherited defaults, through <option selected disabled>.
These should show as readonly in the same way that browsers handle a native <select multiple>.
At the moment, chosen.js allows to remove them (through keyboard backspace or the delete icon),
which is not the expected behaviour.

Apart from removing the delete icon, they should also
be styled differently to communicate their state better - probably with a lower contrast border/text styling?

Note: This is different from tickets around marking the whole field disabled (<select disabled>),
or not allowing to choose options marked as<option disabled>. Looked for related tickets,
but couldn't find any direct matches (loosely related are #488, #248, f1e1c55, #67, #327).

The browser default styling and chosen.js sample can be reviewed here: http://jsfiddle.net/vUQVL/

@pfiller
Copy link
Contributor

pfiller commented May 26, 2012

This is addressed in #638 and should be merged soon.

@pfiller
Copy link
Contributor

pfiller commented Sep 4, 2012

#638 has been merged. This is now fixed in master.

@pfiller pfiller closed this as completed Sep 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants