feat!: support multiple commits in footer #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 85.04% 85.15% +0.10%
==========================================
Files 48 48
Lines 5838 5894 +56
Branches 542 520 -22
==========================================
+ Hits 4965 5019 +54
- Misses 872 874 +2
Partials 1 1
Continue to review full report at Codecov.
|
epope18
approved these changes
Jan 7, 2021
epope18
approved these changes
Jan 7, 2021
codyoss
reviewed
Jan 7, 2021
bcoe
commented
Jan 7, 2021
| (node: FooterNodes) => { | ||
| switch (node.type) { | ||
| case 'scope': | ||
| footerText += `(${node.value})`; |
There was a problem hiding this comment.
This is necessary because we don't currently include ( and ) in the parser, I'd like to add a parenthesis node, which would simplify logic.
chingor13
reviewed
Jan 7, 2021
src/conventional-commits.ts
Outdated
| @@ -71,6 +71,30 @@ interface Note { | |||
| text: string; | |||
| } | |||
|
|
|||
| function getParsedCommits(commits: Commit[]) { | |||
There was a problem hiding this comment.
Can you add the return type?
JustinBeckwith
approved these changes
Jan 7, 2021
chingor13
requested changes
Jan 7, 2021
chingor13
approved these changes
Jan 8, 2021
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [9.0.0](https://www.github.com/googleapis/release-please/compare/v8.2.0...v9.0.0) (2021-01-08) ### ⚠ BREAKING CHANGES * support multiple commits in footer (#686) ### Features * support multiple commits in footer ([#686](https://www.github.com/googleapis/release-please/issues/686)) ([b3f96d8](https://www.github.com/googleapis/release-please/commit/b3f96d8dd988b7d482223e8a7868a45043db4880)) ### Bug Fixes * `findFilesByfilename` respects `path` option ([#665](https://www.github.com/googleapis/release-please/issues/665)) ([a3a1df6](https://www.github.com/googleapis/release-please/commit/a3a1df690f48b38c539ee5aab5ae046d640c6811)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: footers that look like commits will now be displayed in the CHANGELOG.
This PR adds support for expanding multiple commits, represented by a single commit message, into multiple commits in the CHANGELOG.
It expects the format:
Where:
meta: multiple commits, can be anything), there are footers that looks like Conventional Commits.Refs: #667
Fixes: #614
CC: @miraleung