New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: findFilesByfilename
respects path
option
#665
fix: findFilesByfilename
respects path
option
#665
Conversation
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
- Coverage 85.05% 85.04% -0.01%
==========================================
Files 48 48
Lines 5821 5838 +17
Branches 539 542 +3
==========================================
+ Hits 4951 4965 +14
- Misses 869 872 +3
Partials 1 1
Continue to review full report at Codecov.
|
I wasn't quite up to adding a |
@joeldodge79 I'm on a vacation for the next few days, very much appreciate the patch, will look soon. |
@joeldodge79 this looks like a good fix to me 👍 |
scope code search to `path` and return paths relative to `path`. update python releaser to call `findFilesByfilename` appropriately.
356bbe6
to
3fea008
Compare
@bcoe sorry for the lag, I was completely unplugged for the past two weeks. I just rebased the branch. There's still the codecov issue for |
🤖 I have created a release \*beep\* \*boop\* --- ## [9.0.0](https://www.github.com/googleapis/release-please/compare/v8.2.0...v9.0.0) (2021-01-08) ### ⚠ BREAKING CHANGES * support multiple commits in footer (#686) ### Features * support multiple commits in footer ([#686](https://www.github.com/googleapis/release-please/issues/686)) ([b3f96d8](https://www.github.com/googleapis/release-please/commit/b3f96d8dd988b7d482223e8a7868a45043db4880)) ### Bug Fixes * `findFilesByfilename` respects `path` option ([#665](https://www.github.com/googleapis/release-please/issues/665)) ([a3a1df6](https://www.github.com/googleapis/release-please/commit/a3a1df690f48b38c539ee5aab5ae046d640c6811)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
scope code search to
path
and return paths relative topath
.update python releaser to call
findFilesByfilename
appropriately.Fixes #664