New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go): support pseudo context aware commits #667
Conversation
Go regen PRs now enumerate all of the changes they contain. This adds logic to parse those changes so individual entries appear in the changelog. Example PR: googleapis/google-cloud-go#3391
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 83.01% 83.03% +0.01%
==========================================
Files 45 45
Lines 5323 5352 +29
Branches 446 452 +6
==========================================
+ Hits 4419 4444 +25
- Misses 903 907 +4
Partials 1 1
Continue to review full report at Codecov.
|
@codyoss how much control do you have over the format of this upstream PR, I've been working on a grammar for conventional commits that would parse multiple commits in one PR: https://github.com/conventional-commits/parser#the-grammar I was picturing it would look like this:
Or alternatively
The difference being, no My reasoning is that this allows us to extend on the already supported CC: @miraleung |
I have some control. All I do is create the "Changes" section and add bullets to each new commit. I do no formatting the the commits themselves. Between the two suggestions you provided I would lean towards the second as the first is hard to grok as a human. Although I think what is currently there is still reads better for humans. If there is not a standard way to do this today I would prefer to just keep this for now, and iterate later when something solid is locked down. |
Closing in favor of #686 |
Go regen PRs now enumerate all of the changes they contain. This
adds logic to parse those changes so individual entries appear in
the changelog. Example PR: googleapis/google-cloud-go#3391