Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'Client.from_service_account_info' factory #54

Merged
merged 2 commits into from Jun 14, 2021
Merged

feat: add 'Client.from_service_account_info' factory #54

merged 2 commits into from Jun 14, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 10, 2020

Closes #8.

@tseaver tseaver requested a review from a team as a code owner December 10, 2020 18:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@tseaver tseaver mentioned this pull request May 4, 2021
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Jun 11, 2021 •
edited

Note: some of these changes are spurious, introduced by my use of pre-commit, which blackened the source at the time. I have opened #98 to track the fact that we don't use black in this repository.

Update: I have rebased against master and removed the spurious black-generated changes.

@tseaver tseaver requested a review from tswast June 11, 2021 20:47
@tseaver tseaver force-pushed the 8-add-client-factory-from-dict branch from 8fe5882 to 00bd98d Compare June 11, 2021 20:55
@tseaver tseaver merged commit 7e59360 into master Jun 14, 2021
@tseaver tseaver deleted the 8-add-client-factory-from-dict branch June 14, 2021 16:49
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 14, 2021
@release-please
chore: release 1.7.0 (#101)
e1c8d77 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.7.0](https://www.github.com/googleapis/python-cloud-core/compare/v1.6.0...v1.7.0) (2021-06-14)


### Features

* add 'Client.close' ([#100](https://www.github.com/googleapis/python-cloud-core/issues/100)) ([7387fc8](https://www.github.com/googleapis/python-cloud-core/commit/7387fc87186defff74612cf85909c7d456155d47))
* add 'Client.from_service_account_info' factory ([#54](https://www.github.com/googleapis/python-cloud-core/issues/54)) ([7e59360](https://www.github.com/googleapis/python-cloud-core/commit/7e59360a43418947cbbb7608aa23ef5d566c964c))


### Documentation

* update python contributing guide ([#80](https://www.github.com/googleapis/python-cloud-core/issues/80)) ([58deef8](https://www.github.com/googleapis/python-cloud-core/commit/58deef8ce2e90415a4c38022e88fdfe25bc666b6))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@busunkim96 busunkim96 mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create client from service account stored in string
2 participants
@tseaver @busunkim96