Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'Client.close' #100

Merged
merged 3 commits into from Jun 14, 2021
Merged

feat: add 'Client.close' #100

merged 3 commits into from Jun 14, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 11, 2021

FBO use with 'contextlib.closing'.

Closes #64.

@tseaver tseaver requested a review from a team as a code owner June 11, 2021 20:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2021
Copy link

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I hadn't heard of contextlib.closing.

@tseaver tseaver merged commit 7387fc8 into master Jun 14, 2021
@tseaver tseaver deleted the 64-add-client-close branch June 14, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients do not clean up Requests sessions
2 participants