Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert "feat: add always_use_jwt_access" #722

Merged
merged 1 commit into from Jun 25, 2021
Merged

chore: revert "feat: add always_use_jwt_access" #722

merged 1 commit into from Jun 25, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 25, 2021

Reverts #714

@tseaver tseaver requested review from plamut, busunkim96 and a team June 25, 2021 19:28
@tseaver tseaver requested a review from a team as a code owner June 25, 2021 19:28
@tseaver tseaver requested review from shollyman and removed request for a team June 25, 2021 19:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 25, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Jun 25, 2021

I don't know if the release bot will be able to figure it out, but this PR should undo the need for #711.

jimfulton
jimfulton approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@jimfulton jimfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping I'm not missing something.

@tseaver tseaver merged commit 36b6a85 into master Jun 25, 2021
@tseaver tseaver deleted the revert-714-owl-bot-9905973e-8379-4288-8fa6-ea358d9341c1 branch June 25, 2021 20:59
@plamut
Copy link
Contributor

plamut commented Jun 28, 2021

Hoping I'm not missing something.

You are (were) not, reverting that unwanted change was the right thing to do. 👍

plamut
plamut reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut plamut mentioned this pull request Jun 30, 2021
Closed
This was referenced Jul 13, 2021
Merged
Closed
@tseaver tseaver mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut left review comments

@jimfulton jimfulton jimfulton approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @plamut @jimfulton