fix: disable always_use_jwt_access #732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
fix: disable always_use_jwt_access Committer: @busunkim96 PiperOrigin-RevId: 382142900 Source-Link: googleapis/googleapis@513440f Source-Link: googleapis/googleapis-gen@7b1e2c3
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
trusted-contributions-gcf
bot
added
kokoro:force-run
parthea
changed the title
parthea
approved these changes
Jun 30, 2021
parthea
added
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
the
kokoro:force-run
|
@parthea This PR does not do what the title says, and the coverage threshold really shouldn't have been removed. We actually had to revert the very same change a few days ago. Where does this change come from, can it be fixed in the generator? Edit:: Ah, sorry, this was closed, not merged. Nevermind then, sorry for the noise. |
|
@plamut We could exclude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: disable always_use_jwt_access
Committer: @busunkim96
PiperOrigin-RevId: 382142900
Source-Link: googleapis/googleapis@513440f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/7b1e2c31233f79a704ec21ca410bf661d6bc68d0