Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples.samples.snippets_test: many tests failed #437

Closed
flaky-bot bot opened this issue Jul 29, 2021 · 5 comments
Closed

samples.samples.snippets_test: many tests failed #437

flaky-bot bot opened this issue Jul 29, 2021 · 5 comments
Assignees
Labels
api: spanner Issues related to the googleapis/python-spanner API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jul 29, 2021

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

  • test_create_instance
  • test_create_database
  • test_create_database_with_encryption_config
  • test_insert_data
  • test_delete_data
  • test_query_data
  • test_add_column
  • test_read_data
  • test_update_data
  • test_read_stale_data
  • test_read_write_transaction
  • test_query_data_with_new_column
  • test_add_index (samples.samples.snippets_test: test_add_index failed #403)
  • test_query_data_with_index (samples.samples.snippets_test: test_query_data_with_index failed #404)
  • test_read_data_with_index (samples.samples.snippets_test: test_read_data_with_index failed #405)
  • test_add_storing_index
  • test_read_data_with_storing_index
  • test_read_only_transaction
  • test_add_timestamp_column
  • test_update_data_with_timestamp
  • test_query_data_with_timestamp
  • test_create_table_with_timestamp
  • test_insert_data_with_timestamp
  • test_write_struct_data
  • test_query_with_struct
  • test_query_with_array_of_struct
  • test_query_struct_field
  • test_query_nested_struct_field
  • test_insert_data_with_dml
  • test_log_commit_stats
  • test_update_data_with_dml
  • test_delete_data_with_dml
  • test_update_data_with_dml_timestamp
  • test_dml_write_read_transaction
  • test_update_data_with_dml_struct
  • test_insert_with_dml
  • test_query_data_with_parameter
  • test_write_with_dml_transaction
  • test_create_table_with_datatypes
  • test_insert_datatypes_data
  • test_query_data_with_array
  • test_query_data_with_bool
  • test_query_data_with_bytes
  • test_query_data_with_date
  • test_query_data_with_float
  • test_query_data_with_int
  • test_query_data_with_string
  • test_add_numeric_column
  • test_update_data_with_numeric
  • test_query_data_with_numeric_parameter
  • test_query_data_with_timestamp_parameter
  • test_query_data_with_query_options
  • test_create_client_with_query_options (samples.samples.snippets_test: test_create_client_with_query_options failed #406)

commit: 2487800
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 29, 2021
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Jul 29, 2021
@larkee
Copy link
Contributor

larkee commented Jul 29, 2021

@tseaver All of the samples and system tests are suddenly timing out. Looks related to: #427

Is this an issue in other libraries? I need to do a release so I'd like to either resolve the issue or revert that change. WDYT?

@tseaver
Copy link
Contributor

tseaver commented Jul 29, 2021

I know that we have reverted / disable always_use_jwt_access PRs in other libraries (googleapis/python-bigquery#722, googleapis/python-bigtable#348), in some cases followed by a different enabling PR (googleapis/python-bigtable#397). That latter PR, however, looks a lot like our #427. :(

@tseaver
Copy link
Contributor

tseaver commented Jul 29, 2021

At least some of the failures I'm seeing are due to timeouts in instance creation, exceeding 120 seconds. Do we have some way to ask the back-end folks if they have had recent lags in provisioning instances?

@tseaver
Copy link
Contributor

tseaver commented Jul 29, 2021

The multiple snippets failures may be due to insufficient dependencies (or I implemented the pytest-dependency bits wrong). They do all seem to be either timeouts (for instance creation) or NotFound errors for the instance / database being used.

@tseaver tseaver added type: process A process-related concern. May include testing, release, or the like. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 29, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 30, 2021

Test passed for commit 89fe076 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants