fix: remove local copy of beam I/O now that it is merged to upstream #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
anguillanneuf
previously requested changes
Sep 13, 2021
There was a problem hiding this comment.
- Please also remove
pubsublite-beam-iofromversions.txt. - Is the PubsubLiteIO in Beam version
2.32.0equivalent to version0.19.5here? If not, we may consider removing the files here after the next Beam release. - Please also resolve the merge conflicts. Thank you!
- Please also update this JIRA ticket: https://issues.apache.org/jira/browse/BEAM-10114
- (FYI) sample has been updated: feat: update sample to use beam-side lite io GoogleCloudPlatform/java-docs-samples#5312. Docs too. (cl/396653855)
dpcollins-google
force-pushed
the
remove-beam
branch
from
6efddd6
to
529c1d2
Compare
dpcollins-google
added
the
do not merge
Done
Version 2.33.0 will be equivalent, I'll add a DO_NOT_MERGE label for now.
Done
Done
|
dpcollins-google
force-pushed
the
remove-beam
branch
from
568cfbb
to
bf5c15d
Compare
dpcollins-google
removed
the
do not merge
manuelmenzella-google
approved these changes
Nov 22, 2021
dpcollins-google
dismissed
anguillanneuf’s stale review
Implemented changes, reviewer on vacation.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.4.1](https://www.github.com/googleapis/java-pubsublite/compare/v1.4.0...v1.4.1) (2021-12-03) ### Bug Fixes * remove local copy of beam I/O now that it is merged to upstream ([#873](https://www.github.com/googleapis/java-pubsublite/issues/873)) ([0bd9d52](https://www.github.com/googleapis/java-pubsublite/commit/0bd9d52e1da3029281f67e3e323e7fca890d2fee)) ### Dependencies * update beam.version to v2.34.0 ([#950](https://www.github.com/googleapis/java-pubsublite/issues/950)) ([527f77f](https://www.github.com/googleapis/java-pubsublite/commit/527f77fabc59c8b294e119d0d68384b47624f0b9)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([#952](https://www.github.com/googleapis/java-pubsublite/issues/952)) ([41ebb30](https://www.github.com/googleapis/java-pubsublite/commit/41ebb30bbfc729f1df3b0dc189dd4823e0af7360)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#960](https://www.github.com/googleapis/java-pubsublite/issues/960)) ([9e46dbc](https://www.github.com/googleapis/java-pubsublite/commit/9e46dbc52085e0bbfa6c14d2d7892608a1d2fa7a)) * update dependency com.google.cloud:pubsublite-beam-io to v0.23.0 ([#951](https://www.github.com/googleapis/java-pubsublite/issues/951)) ([c62c79c](https://www.github.com/googleapis/java-pubsublite/commit/c62c79c21bca315740e9298e35a57e8ff08de4db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.