Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release pubsub 1.9.0 #3343

Closed
wants to merge 1 commit into from
Closed

chore: release pubsub 1.9.0 #3343

wants to merge 1 commit into from

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Dec 3, 2020 •
edited

馃 I have created a release *beep* *boop*

1.9.0 (2020-12-03)

Features

  • pubsub: Allow Message and PublishResult to be used outside the package (#3200) (581bf92)
  • pubsub: Enable server side flow control by default with the option to turn it off (#3154) (e392e61)

Bug Fixes

  • pubsub: Remove NewMessage and NewPublishResult (#3232) (a781a3a)

This PR was generated with Release Please.

@release-please release-please bot requested a review from a team as a code owner December 3, 2020 16:19
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@hongalex hongalex requested a review from tmdiep December 3, 2020 19:01
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@tmdiep
Copy link
Contributor

tmdiep commented Dec 3, 2020

Oh no, release-please overwrote your manual changes!

I was just going to comment that perhaps we should reword to something like:
"However, the decision was made to only allow packages in google-cloud-go to access NewMessage and NewPublishResult (see #3351)."

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@release-please release-please bot closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmdiep tmdiep Awaiting requested review from tmdiep

Assignees
No one assigned
Labels
autorelease: closed cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmdiep @kokoro-team @yoshi-automation