Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): Remove NewMessage and NewPublishResult #3232

Merged
merged 2 commits into from Nov 19, 2020

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Nov 19, 2020

Rolls back the public functions added in #3200. We have decided not to expose these to users.

We have decided not to expose these to users.
@tmdiep tmdiep requested a review from a team as a code owner November 19, 2020 06:39
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Nov 19, 2020
@tmdiep tmdiep requested a review from hongalex November 19, 2020 06:40
@tmdiep
Copy link
Contributor Author

tmdiep commented Nov 19, 2020

Submitting in case we need to do a pubsub release before this issue is resolved.

@tmdiep tmdiep merged commit a781a3a into googleapis:master Nov 19, 2020
@tmdiep tmdiep deleted the pubsub_partial_rollback branch November 19, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants