feat(pubsub): Enable server side flow control by default with the option to turn it off #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn it off This change enables sending flow control settings automatically to the server. If ReceiveSettings.MaxOutstandingMessages > 0 or ReceiveSettings.MaxOutstandingBytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and ReceiveSettings.UseLegacyFlowControl can be set for users who would like to opt-out of this feature in case they encounter issues with server side flow control.
google-cla
bot
added
the
cla: yes
codyoss
changed the title
|
@fayssalmartanigcp Thank you for the contribution. Is there an issue associated with this PR, if not would you mind opening one? |
hongalex
reviewed
Nov 6, 2020
hongalex
approved these changes
Nov 10, 2020
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
hongalex
reviewed
Nov 10, 2020
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
hongalex
reviewed
Nov 11, 2020
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables sending flow control settings automatically to the server.
If ReceiveSettings.MaxOutstandingMessages > 0 or ReceiveSettings.MaxOutstandingBytes > 0,
flow control will be enforced at the server side (in addition to the client side).
This behavior is enabled by default and ReceiveSettings.UseLegacyFlowControl can be set for users
who would like to opt-out of this feature in case they encounter issues with server side flow
control.