Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert usages of Status constructor calls to internal helpers in make_status.h #14107

Closed
20 tasks done
alevenberg opened this issue May 1, 2024 · 7 comments
Closed
20 tasks done

Convert usages of Status constructor calls to internal helpers in make_status.h #14107

alevenberg opened this issue May 1, 2024 · 7 comments
Assignees
@alevenberg
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@alevenberg
Copy link
Member

alevenberg commented May 1, 2024 •
edited

Make changes like #14088 for any client created status

Generator for StatusCode::kCancelled

Bigtable for StatusCode::kCancelled

Storage

Pub/Sub

I think I can write a regex python script for the rest.

Ran python3 scripts/rename_status.py google/cloud/internal in b/scripts2
More

  • cleanup(pubsublite): use Status factory functions
  • cleanup(spanner): use Status factory functions in spanner/internal
  • cleanup(spanner): use Status factory functions in spanner
  • cleanup(spanner): useStatus factory functions in spanner/testing
  • cleanup: use Status factory functions in internal
  • cleanup: use Status factory functions in testing_util/*
  • generator
generator/internal/codegen_utils.cc:    return Status(StatusCode::kInvalidArgument,
generator/internal/descriptor_utils.cc:    return Status(StatusCode::kNotFound,
generator/internal/descriptor_utils.cc:        StatusCode::kInternal,
generator/internal/service_code_generator.cc:    return Status(StatusCode::kInternal,
generator/standalone_main.cc:  return google::cloud::Status(google::cloud::StatusCode::kInvalidArgument,
  • Bigtable
google/cloud/bigtable/table.cc:        Status(StatusCode::kInvalidArgument,
google/cloud/bigtable/table_resource.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/bigtable/test_proxy/cbt_test_proxy.cc:    return Status(StatusCode::kNotFound,
google/cloud/bigtable/benchmarks/mutation_batcher_throughput_options.cc:    auto const code = google::cloud::StatusCode::kInvalidArgument;
und) {
google/cloud/bigtable/examples/howto_mock_data_api.cc:  gc::Status final_status(gc::StatusCode::kPermissionDenied, "fail");
google/cloud/bigtable/examples/table_admin_snippets.cc:      if (table.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/examples/table_admin_snippets.cc:        table.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/instance_resource.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/bigtable/internal/bulk_mutator.cc:            StatusCode::kInternal,
google/cloud/bigtable/internal/bulk_mutator.cc:          StatusCode::kInternal,
google/cloud/bigtable/internal/data_connection_impl.cc:        StatusCode::kInternal,
google/cloud/bigtable/benchmarks/benchmark.cc:      return google::cloud::Status(google::cloud::StatusCode::kUnknown,
google/cloud/bigtable/benchmarks/benchmark_options.cc:    auto const code = google::cloud::StatusCode::kInvalidArgument;
google/cloud/bigtable/benchmarks/mutation_batcher_throughput_benchmark.cc:      return Status(StatusCode::kUnknown, std::move(os).str());
  • internal
google/cloud/internal/rest_response.cc:    return StatusCode::kUnavailable;
google/cloud/internal/parse_rfc3339.cc:        StatusCode::kInvalidArgument,
google/cloud/internal/openssl/parse_service_account_p12_file.cc:    return Status(StatusCode::kInvalidArgument, msg);
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,,
google/cloud/internal/oauth2_compute_engine_credentials.cc:    return Status{StatusCode::kInvalidArgument, error_payload, {}};{
google/cloud/internal/oauth2_google_credentials.cc:          StatusCode::kInvalidArgument,
google/cloud/internal/oauth2_service_account_credentials.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/oauth2_authorized_user_credentials.cc:      return Status(StatusCode::kInvalidArgument,
google/cloud/internal/grpc_impersonate_service_account.cc:      if (!self) return Status{StatusCode::kUnknown, "lost reference"};
google/cloud/internal/extract_long_running_result.cc:    return Status(StatusCode::kInternal,
google/cloud/internal/default_completion_queue_impl.cc:    return Status{StatusCode::kCancelled, "timer canceled"};
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kInternal;
google/cloud/internal/async_polling_loop.cc:            StatusCode::kDeadlineExceeded,
google/cloud/internal/base64_transforms.cc:  return Status(StatusCode::kInvalidArgument,
  • kms_key_name
google/cloud/kms_key_name.cc:    return Status(StatusCode::kInvalidArgument,
  • location
google/cloud/location.cc:    return Status(StatusCode::kInvalidArgument,
  • project
google/cloud/project.cc:    return Status(StatusCode::kInvalidArgument,
  • pubsub
google/cloud/pubsub/benchmarks/endurance.cc:    return google::cloud::Status(google::cloud::StatusCode::kInvalidArgument,
google/cloud/pubsub/benchmarks/endurance.cc:    return google::cloud::Status(google::cloud::StatusCode::kUnknown,
google/cloud/pubsub/benchmarks/throughput.cc:    return google::cloud::Status(google::cloud::StatusCode::kInvalidArgument,
google/cloud/pubsub/benchmarks/throughput.cc:    return google::cloud::Status(google::cloud::StatusCode::kUnknown,
  • pubsublite
google/cloud/pubsublite/endpoint.cc:        StatusCode::kInvalidArgument,
google/cloud/pubsublite/internal/cloud_region.cc:    return Status{StatusCode::kInvalidArgument, "Invalid region name"};
google/cloud/pubsublite/internal/cloud_zone.cc:    return Status{StatusCode::kInvalidArgument, "Invalid zone name"};
google/cloud/pubsublite/internal/default_publish_message_transformer.cc:        return Status{StatusCode::kInvalidArgument,
google/cloud/pubsublite/internal/location.cc:  return Status{StatusCode::kInvalidArgument, "Invalid location"};
google/cloud/pubsublite/internal/multipartition_publisher.cc:          return Status{StatusCode::kInternal,
google/cloud/pubsublite/internal/partition_publisher.cc:        StatusCode::kAborted,
google/cloud/pubsublite/internal/partition_publisher.cc:        Status(StatusCode::kFailedPrecondition,
google/cloud/pubsublite/message_metadata.cc:  return Status{StatusCode::kInvalidArgument,
google/cloud/pubsublite/publisher_connection.cc:      return Status{StatusCode::kInvalidArgument, "`topic` not valid"};
  • spanner
google/cloud/spanner/backup.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/spanner/benchmarks/benchmarks_config.cc:    return google::cloud::Status(google::cloud::StatusCode::kInvalidArgument,
google/cloud/spanner/database.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/spanner/instance.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/spanner/internal/connection_impl.cc:  return Status(StatusCode::kInternal,
google/cloud/spanner/internal/partial_result_set_source.cc:      return Status(StatusCode::kInternal,
google/cloud/spanner/internal/partial_result_set_source.cc:        return Status(StatusCode::kInternal,
google/cloud/spanner/internal/partial_result_set_source.cc:        return Status(StatusCode::kInternal,
google/cloud/spanner/internal/status_utils.cc:  if (status.code() != StatusCode::kNotFound) return false;
google/cloud/spanner/numeric.cc:  return Status(StatusCode::kInvalidArgument, std::move(message));
google/cloud/spanner/numeric.cc:  return Status(StatusCode::kOutOfRange, std::move(message));
google/cloud/spanner/numeric.cc:  return Status(StatusCode::kDataLoss, std::move(message));
google/cloud/spanner/sql_statement.cc:  return Status(StatusCode::kNotFound, "No such parameter: " + parameter_name);
google/cloud/spanner/testing/instance_location.cc:  return Status(StatusCode::kUnavailable,
google/cloud/spanner/testing/pick_random_instance.cc:      return Status(StatusCode::kInternal,
google/cloud/spanner/timestamp.cc:  return Status(StatusCode::kOutOfRange, std::move(message));
google/cloud/spanner/timestamp.cc:  return Status(StatusCode::kInvalidArgument, std::move(message));
google/cloud/spanner/value.cc:    return Status(StatusCode::kUnknown,
google/cloud/spanner/value.cc:  return Status(StatusCode::kInvalidArgument,
@alevenberg alevenberg added the type: cleanup An internal cleanup or hygiene concern. label May 1, 2024
@alevenberg alevenberg self-assigned this May 1, 2024
@alevenberg
Copy link
Member Author

Found changes by searching for StatusCode::kCancelled

@alevenberg alevenberg mentioned this issue May 6, 2024
Merged
@coryan
Copy link
Member

coryan commented May 6, 2024

This may be useful (find all StatusCode::k that are not StatusCode::kOk in .cc files that are not test files):

git grep -e 'StatusCode::k'  --and --not -e 'StatusCode::kOk' -- '*.cc' ':!*_test.cc'

There are a lot of StatusCode::kUnimplemented in generated code, so maybe exclude them because the fix is well understood:

git grep -e 'StatusCode::k' --and --not -e 'StatusCode::kUnimplemented' --and --not -e 'StatusCode::kOk' -- '*.cc' ':!*_test.cc'

@alevenberg alevenberg mentioned this issue May 6, 2024
Merged
@coryan coryan mentioned this issue May 7, 2024
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@alevenberg
Copy link
Member Author

Once the next two PRs are merged, we can check if we missed anything and then close the issue

@alevenberg
Copy link
Member Author

alevenberg commented May 13, 2024 •
edited

This is what's currently left. Some (maybe all) are false positives:

ci/cloudbuild/notifiers/logs/function/function.cc:    if (metadata.status().code() != StatusCode::kFailedPrecondition) {
examples/gcs2cbt.cc:      schema.status().code() != google::cloud::StatusCode::kAlreadyExists) {
examples/grpc_credential_types.cc:  if (status == 400) return Status(StatusCode::kInvalidArgument, buffer);
examples/grpc_credential_types.cc:  if (status == 401) return Status(StatusCode::kUnauthenticated, buffer);
examples/grpc_credential_types.cc:  if (status == 403) return Status(StatusCode::kPermissionDenied, buffer);
examples/grpc_credential_types.cc:  if (status >= 500) return Status(StatusCode::kInternal, buffer);
examples/grpc_credential_types.cc:    return Status(StatusCode::kUnknown, buffer);
examples/grpc_credential_types.cc:          google::cloud::StatusCode::kUnauthenticated) {
generator/integration_tests/golden/v1/golden_thing_admin_client.cc:        result.status().code() != StatusCode::kAborted ||
generator/internal/client_generator.cc:             "        result.status().code() != StatusCode::kAborted ||\n"
generator/internal/codegen_utils.cc:    return Status(StatusCode::kInvalidArgument,
generator/internal/descriptor_utils.cc:    return Status(StatusCode::kNotFound,
generator/internal/descriptor_utils.cc:        StatusCode::kInternal,
generator/internal/service_code_generator.cc:    return Status(StatusCode::kInternal,
generator/standalone_main.cc:  return google::cloud::Status(google::cloud::StatusCode::kInvalidArgument,
google/cloud/bigtable/admin/bigtable_instance_admin_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/bigtable/admin/bigtable_table_admin_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/bigtable/benchmarks/benchmark_options.cc:    auto const code = google::cloud::StatusCode::kInvalidArgument;
google/cloud/bigtable/examples/bigtable_instance_admin_snippets.cc:      if (instance.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/examples/howto_mock_data_api.cc:  gc::Status final_status(gc::StatusCode::kPermissionDenied, "fail");
google/cloud/bigtable/examples/table_admin_snippets.cc:      if (table.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/examples/table_admin_snippets.cc:        table.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/internal/data_tracing_connection.cc:                                  : opentelemetry::trace::StatusCode::kError);
google/cloud/bigtable/internal/legacy_async_row_reader.cc:  Status status(StatusCode::kCancelled, reason);
google/cloud/bigtable/internal/legacy_async_row_sampler.cc:          Status(StatusCode::kCancelled, "call cancelled"));
google/cloud/bigtable/internal/legacy_row_reader.cc:    return Status(StatusCode::kCancelled, "Operation cancelled.");
google/cloud/billing/v1/cloud_billing_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/containeranalysis/v1/container_analysis_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/datacatalog/v1/data_catalog_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kCancelled;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kUnknown;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kInvalidArgument;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kDeadlineExceeded;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kNotFound;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kAlreadyExists;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kPermissionDenied;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kUnauthenticated;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kResourceExhausted;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kFailedPrecondition;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kAborted;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kOutOfRange;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kInternal;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kUnavailable;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kDataLoss;
google/cloud/grpc_error_delegate.cc:      return google::cloud::StatusCode::kUnknown;
google/cloud/grpc_error_delegate.cc:  StatusCode code = StatusCode::kUnknown;
google/cloud/grpc_error_delegate.cc:      proto.code() <= static_cast<std::int32_t>(StatusCode::kUnauthenticated)) {
google/cloud/iam/admin/v1/iam_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/internal/async_polling_loop.cc:            StatusCode::kDeadlineExceeded,
google/cloud/internal/base64_transforms.cc:  return Status(StatusCode::kInvalidArgument,
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kPermissionDenied;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kDeadlineExceeded;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kInvalidArgument;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kAborted;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kNotFound;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc:      code = StatusCode::kUnavailable;
google/cloud/internal/curl_writev.cc:  // These errors are treated as `StatusCode::kUnavailable` and thus retryable
google/cloud/internal/debug_string_status.cc:        case StatusCode::kInvalidArgument:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kFailedPrecondition:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kOutOfRange:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kNotFound:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kAlreadyExists:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kResourceExhausted:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kDataLoss:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kUnknown:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kInternal:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kUnavailable:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kDeadlineExceeded:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kUnauthenticated:  // NOLINT(bugprone-branch-clone)
google/cloud/internal/debug_string_status.cc:        case StatusCode::kPermissionDenied:
google/cloud/internal/debug_string_status.cc:        case StatusCode::kAborted:
google/cloud/internal/default_completion_queue_impl.cc:    return Status{StatusCode::kCancelled, "timer canceled"};
google/cloud/internal/extract_long_running_result.cc:    return Status(StatusCode::kInternal,
google/cloud/internal/extract_long_running_result.cc:        StatusCode::kInternal,
google/cloud/internal/extract_long_running_result.cc:    return Status(StatusCode::kInternal,
google/cloud/internal/extract_long_running_result.cc:        StatusCode::kInternal,
google/cloud/internal/grpc_impersonate_service_account.cc:      if (!self) return Status{StatusCode::kUnknown, "lost reference"};
google/cloud/internal/make_status.cc:  return Status(StatusCode::kCancelled, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kUnknown, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kInvalidArgument, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kDeadlineExceeded, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kNotFound, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kAlreadyExists, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kPermissionDenied, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kUnauthenticated, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kResourceExhausted, std::move(msg),
google/cloud/internal/make_status.cc:  return Status(StatusCode::kFailedPrecondition, std::move(msg),
google/cloud/internal/make_status.cc:  return Status(StatusCode::kAborted, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kOutOfRange, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kInternal, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kUnavailable, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kDataLoss, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kCancelled, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kCancelled));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kUnknown, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kUnknown));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kInvalidArgument, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kInvalidArgument));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kDeadlineExceeded, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kDeadlineExceeded));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kNotFound, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kNotFound));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kAlreadyExists, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kAlreadyExists));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kPermissionDenied, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kPermissionDenied));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kUnauthenticated, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kUnauthenticated));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kResourceExhausted, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kResourceExhausted));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kFailedPrecondition, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kFailedPrecondition));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kAborted, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kAborted));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kOutOfRange, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kOutOfRange));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kInternal, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kInternal));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kUnavailable, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kUnavailable));
google/cloud/internal/make_status.cc:  return Status(StatusCode::kDataLoss, std::move(msg),
google/cloud/internal/make_status.cc:                std::move(b).Build(StatusCode::kDataLoss));
google/cloud/internal/oauth2_authorized_user_credentials.cc:        StatusCode::kInvalidArgument,
google/cloud/internal/oauth2_authorized_user_credentials.cc:      return Status(StatusCode::kInvalidArgument,
google/cloud/internal/oauth2_authorized_user_credentials.cc:      return Status(StatusCode::kInvalidArgument,
google/cloud/internal/oauth2_compute_engine_credentials.cc:           status.code() != StatusCode::kUnavailable;
google/cloud/internal/oauth2_compute_engine_credentials.cc:    return Status{StatusCode::kInvalidArgument, error_payload, {}};
google/cloud/internal/oauth2_compute_engine_credentials.cc:    if ((*response)->StatusCode() == rest_internal::HttpStatusCode::kNotFound) {
google/cloud/internal/oauth2_google_credentials.cc:    return Status(StatusCode::kUnknown, "Cannot open credentials file " + path);
google/cloud/internal/oauth2_google_credentials.cc:          StatusCode::kInvalidArgument,
google/cloud/internal/oauth2_google_credentials.cc:      StatusCode::kInvalidArgument,
google/cloud/internal/oauth2_service_account_credentials.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/openssl/parse_service_account_p12_file.cc:    return Status(StatusCode::kInvalidArgument, msg);
google/cloud/internal/openssl/parse_service_account_p12_file.cc:    return Status(StatusCode::kInvalidArgument, msg);
google/cloud/internal/openssl/parse_service_account_p12_file.cc:        StatusCode::kInvalidArgument,
google/cloud/internal/openssl/parse_service_account_p12_file.cc:    return Status(StatusCode::kUnknown, msg);
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/openssl/sign_using_sha256.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/internal/opentelemetry.cc:  span.SetStatus(opentelemetry::trace::StatusCode::kError, status.message());
google/cloud/internal/parse_rfc3339.cc:        StatusCode::kInvalidArgument,
google/cloud/internal/rest_response.cc:  return StatusCode::kUnknown;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kResumeIncomplete) {
google/cloud/internal/rest_response.cc:    return StatusCode::kFailedPrecondition;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kNotModified) {
google/cloud/internal/rest_response.cc:    return StatusCode::kFailedPrecondition;
google/cloud/internal/rest_response.cc:  return StatusCode::kUnknown;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kBadRequest) {
google/cloud/internal/rest_response.cc:    return StatusCode::kInvalidArgument;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kUnauthorized) {
google/cloud/internal/rest_response.cc:    return StatusCode::kUnauthenticated;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kForbidden) {
google/cloud/internal/rest_response.cc:    return StatusCode::kPermissionDenied;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kNotFound) {
google/cloud/internal/rest_response.cc:    return StatusCode::kNotFound;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kMethodNotAllowed) {
google/cloud/internal/rest_response.cc:    return StatusCode::kPermissionDenied;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kRequestTimeout) {
google/cloud/internal/rest_response.cc:    return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kConflict) {
google/cloud/internal/rest_response.cc:    return StatusCode::kAborted;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kGone) {
google/cloud/internal/rest_response.cc:    return StatusCode::kNotFound;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kLengthRequired) {
google/cloud/internal/rest_response.cc:    return StatusCode::kInvalidArgument;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kPreconditionFailed) {
google/cloud/internal/rest_response.cc:    return StatusCode::kFailedPrecondition;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kPayloadTooLarge) {
google/cloud/internal/rest_response.cc:    return StatusCode::kOutOfRange;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kRequestRangeNotSatisfiable) {
google/cloud/internal/rest_response.cc:    return StatusCode::kOutOfRange;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kTooManyRequests) {
google/cloud/internal/rest_response.cc:    return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc:  return StatusCode::kInvalidArgument;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kInternalServerError) {
google/cloud/internal/rest_response.cc:    return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kBadGateway) {
google/cloud/internal/rest_response.cc:    return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc:  if (code == HttpStatusCode::kServiceUnavailable) {
google/cloud/internal/rest_response.cc:    return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc:  return StatusCode::kInternal;
google/cloud/internal/rest_response.cc:  return StatusCode::kUnknown;
google/cloud/internal/rest_response.cc:  static_assert(HttpStatusCode::kMinSuccess < HttpStatusCode::kMinNotSuccess,
google/cloud/internal/rest_response.cc:  return response.StatusCode() < HttpStatusCode::kMinNotSuccess &&
google/cloud/internal/rest_response.cc:         response.StatusCode() >= HttpStatusCode::kMinSuccess;
google/cloud/internal/retry_policy_impl.cc:  if (status.code() != StatusCode::kInternal) return false;
google/cloud/internal/streaming_read_rpc.cc:  if (status.ok() || status.code() == StatusCode::kCancelled) return;
google/cloud/internal/streaming_write_rpc_impl.cc:  if (status.ok() || status.code() == StatusCode::kCancelled) return;
google/cloud/opentelemetry/internal/recordable.cc:  if (code == opentelemetry::trace::StatusCode::kUnset) return;
google/cloud/opentelemetry/monitoring_exporter.cc:      if (status.code() == StatusCode::kInvalidArgument &&
google/cloud/opentelemetry/monitoring_exporter.cc:      } else if (status.code() != StatusCode::kInvalidArgument) {
google/cloud/pubsub/benchmarks/endurance.cc:    return google::cloud::Status(google::cloud::StatusCode::kUnknown,
google/cloud/pubsub/benchmarks/throughput.cc:    return google::cloud::Status(google::cloud::StatusCode::kUnknown,
google/cloud/pubsub/internal/exactly_once_policies.cc:  return (code == StatusCode::kDeadlineExceeded ||
google/cloud/pubsub/internal/exactly_once_policies.cc:          code == StatusCode::kResourceExhausted ||
google/cloud/pubsub/internal/exactly_once_policies.cc:          code == StatusCode::kAborted || code == StatusCode::kInternal ||
google/cloud/pubsub/internal/exactly_once_policies.cc:          code == StatusCode::kUnavailable);
google/cloud/pubsub/samples/schema_samples.cc:    if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc:    if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc:    if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc:    if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc:    if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:      if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:      if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (snapshot.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/subscription_admin_samples.cc:    if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/topic_admin_samples.cc:    if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc:    if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc:    if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc:    if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc:    if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/topic_admin_samples.cc:      StatusCode::kInvalidArgument);
google/cloud/pubsublite/internal/partition_publisher.cc:        StatusCode::kAborted,
google/cloud/resourcemanager/v3/folders_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/resourcemanager/v3/tag_keys_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/resourcemanager/v3/tag_values_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/securitycenter/v1/security_center_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/securitycenter/v2/security_center_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/spanner/admin/database_admin_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/spanner/admin/instance_admin_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/spanner/backup.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/spanner/benchmarks/benchmarks_config.cc:    return google::cloud::Status(google::cloud::StatusCode::kInvalidArgument,
google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc:    if (db.status().code() != google::cloud::StatusCode::kUnavailable) break;
google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc:        db.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/spanner/benchmarks/single_row_throughput_benchmark.cc:    if (db.status().code() != google::cloud::StatusCode::kUnavailable) break;
google/cloud/spanner/benchmarks/single_row_throughput_benchmark.cc:        db.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/spanner/database.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/spanner/instance.cc:    return Status(StatusCode::kInvalidArgument,
google/cloud/spanner/internal/connection_impl.cc:  return Status(StatusCode::kInternal,
google/cloud/spanner/internal/partial_result_set_source.cc:    if (!status.ok() && status.code() != StatusCode::kCancelled) {
google/cloud/spanner/internal/partial_result_set_source.cc:      return Status(StatusCode::kInternal,
google/cloud/spanner/internal/partial_result_set_source.cc:        return Status(StatusCode::kInternal,
google/cloud/spanner/internal/partial_result_set_source.cc:        return Status(StatusCode::kInternal,
google/cloud/spanner/internal/status_utils.cc:  if (status.code() != StatusCode::kNotFound) return false;
google/cloud/spanner/numeric.cc:  return Status(StatusCode::kInvalidArgument, std::move(message));
google/cloud/spanner/numeric.cc:  return Status(StatusCode::kOutOfRange, std::move(message));
google/cloud/spanner/numeric.cc:  return Status(StatusCode::kDataLoss, std::move(message));
google/cloud/spanner/samples/postgresql_samples.cc:              google::cloud::StatusCode::kUnknown,
google/cloud/spanner/samples/samples.cc:             google::cloud::StatusCode::kNotFound) {
google/cloud/spanner/samples/samples.cc:             google::cloud::StatusCode::kAborted) {
google/cloud/spanner/samples/samples.cc:              google::cloud::StatusCode::kUnknown,
google/cloud/spanner/samples/samples.cc:      if (status.code() != google::cloud::StatusCode::kFailedPrecondition ||
google/cloud/spanner/sql_statement.cc:  return Status(StatusCode::kNotFound, "No such parameter: " + parameter_name);
google/cloud/spanner/testing/instance_location.cc:  return Status(StatusCode::kUnavailable,
google/cloud/spanner/testing/pick_random_instance.cc:      return Status(StatusCode::kInternal,
google/cloud/spanner/testing/pick_random_instance.cc:      if (instance || instance.status().code() == StatusCode::kAlreadyExists) {
google/cloud/spanner/timestamp.cc:  return Status(StatusCode::kOutOfRange, std::move(message));
google/cloud/spanner/timestamp.cc:  return Status(StatusCode::kInvalidArgument, std::move(message));
google/cloud/spanner/value.cc:    return Status(StatusCode::kUnknown,
google/cloud/spanner/value.cc:  return Status(StatusCode::kInvalidArgument,
google/cloud/status.cc:    case StatusCode::kCancelled:
google/cloud/status.cc:    case StatusCode::kUnknown:
google/cloud/status.cc:    case StatusCode::kInvalidArgument:
google/cloud/status.cc:    case StatusCode::kDeadlineExceeded:
google/cloud/status.cc:    case StatusCode::kNotFound:
google/cloud/status.cc:    case StatusCode::kAlreadyExists:
google/cloud/status.cc:    case StatusCode::kPermissionDenied:
google/cloud/status.cc:    case StatusCode::kUnauthenticated:
google/cloud/status.cc:    case StatusCode::kResourceExhausted:
google/cloud/status.cc:    case StatusCode::kFailedPrecondition:
google/cloud/status.cc:    case StatusCode::kAborted:
google/cloud/status.cc:    case StatusCode::kOutOfRange:
google/cloud/status.cc:    case StatusCode::kInternal:
google/cloud/status.cc:    case StatusCode::kUnavailable:
google/cloud/status.cc:    case StatusCode::kDataLoss:
google/cloud/storage/examples/storage_client_mock_samples.cc:                google::cloud::StatusCode::kInvalidArgument,
google/cloud/storage/examples/storage_client_mock_samples.cc:          google::cloud::StatusCode::kInvalidArgument, "Invalid Argument"}));
google/cloud/storage/examples/storage_object_resumable_write_samples.cc:    if (!status.ok() && status.code() != google::cloud::StatusCode::kNotFound) {
google/cloud/storage/internal/connection_impl.cc:  if (status.code() == StatusCode::kAborted &&
google/cloud/storage/internal/grpc/object_read_source.cc:  result.response.status_code = storage::internal::HttpStatusCode::kContinue;
google/cloud/storage/internal/grpc/stub.cc:  if (code == StatusCode::kFailedPrecondition || code == StatusCode::kAborted) {
google/cloud/storage/internal/grpc/stub.cc:  if (patch.status().code() == StatusCode::kFailedPrecondition) {
google/cloud/storage/internal/grpc/stub.cc:  if (patch.status().code() == StatusCode::kFailedPrecondition) {
google/cloud/storage/internal/grpc/stub.cc:  if (patch.status().code() == StatusCode::kFailedPrecondition) {
google/cloud/storage/internal/http_response.cc:  if (code < 0 || code > 600) return StatusCode::kUnknown;
google/cloud/storage/internal/object_requests.cc:              response.status_code == HttpStatusCode::kCreated;
google/cloud/storage/internal/rest/object_read_source.cc:    h.status_code = HttpStatusCode::kContinue;
google/cloud/storage/internal/rest/stub.cc:  if (!response && response.status().code() == StatusCode::kAborted) {
google/cloud/storage/internal/rest/stub.cc:    return (code != rest::HttpStatusCode::kResumeIncomplete &&
google/cloud/storage/internal/rest/stub.cc:            code >= rest::HttpStatusCode::kMinNotSuccess);
google/cloud/storage/internal/rest/stub.cc:    return (code != rest::HttpStatusCode::kClientClosedRequest &&
google/cloud/storage/internal/rest/stub.cc:            code >= rest::HttpStatusCode::kMinNotSuccess);
google/cloud/storage/internal/rest/stub.cc:    return (code != rest::HttpStatusCode::kResumeIncomplete &&
google/cloud/storage/internal/rest/stub.cc:            code >= rest::HttpStatusCode::kMinNotSuccess);
google/cloud/storage/internal/retry_object_read_source.cc:    if (result->response.status_code != HttpStatusCode::kContinue &&
google/cloud/tasks/v2/cloud_tasks_client.cc:    if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/testing_util/opentelemetry_matchers.cc:    case opentelemetry::trace::StatusCode::kError:
google/cloud/testing_util/opentelemetry_matchers.cc:    case opentelemetry::trace::StatusCode::kUnset:

@alevenberg
Copy link
Member Author

Actually going to wait til the BT PR merges to check

@alevenberg
Copy link
Member Author

ci/cloudbuild/notifiers/logs/function/function.cc: if (metadata.status().code() != StatusCode::kFailedPrecondition) {
examples/gcs2cbt.cc: schema.status().code() != google::cloud::StatusCode::kAlreadyExists) {
examples/grpc_credential_types.cc: if (status == 400) return Status(StatusCode::kInvalidArgument, buffer);
examples/grpc_credential_types.cc: if (status == 401) return Status(StatusCode::kUnauthenticated, buffer);
examples/grpc_credential_types.cc: if (status == 403) return Status(StatusCode::kPermissionDenied, buffer);
examples/grpc_credential_types.cc: if (status >= 500) return Status(StatusCode::kInternal, buffer);
examples/grpc_credential_types.cc: return Status(StatusCode::kUnknown, buffer);
examples/grpc_credential_types.cc: google::cloud::StatusCode::kUnauthenticated) {
generator/integration_tests/golden/v1/golden_thing_admin_client.cc: result.status().code() != StatusCode::kAborted ||
generator/internal/client_generator.cc: " result.status().code() != StatusCode::kAborted ||\n"
google/cloud/bigtable/admin/bigtable_instance_admin_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/bigtable/admin/bigtable_table_admin_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/bigtable/benchmarks/benchmark_options.cc: auto const code = google::cloud::StatusCode::kInvalidArgument;
google/cloud/bigtable/examples/bigtable_instance_admin_snippets.cc: if (instance.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/examples/howto_mock_data_api.cc: gc::Status final_status(gc::StatusCode::kPermissionDenied, "fail");
google/cloud/bigtable/examples/table_admin_snippets.cc: if (table.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/examples/table_admin_snippets.cc: table.status().code() == google::cloud::StatusCode::kNotFound) {
google/cloud/bigtable/internal/data_tracing_connection.cc: : opentelemetry::trace::StatusCode::kError);
google/cloud/bigtable/internal/legacy_async_row_reader.cc: Status status(StatusCode::kCancelled, reason);
google/cloud/bigtable/internal/legacy_async_row_sampler.cc: Status(StatusCode::kCancelled, "call cancelled"));
google/cloud/bigtable/internal/legacy_row_reader.cc: return Status(StatusCode::kCancelled, "Operation cancelled.");
google/cloud/billing/v1/cloud_billing_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/containeranalysis/v1/container_analysis_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/datacatalog/v1/data_catalog_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kCancelled;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kUnknown;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kInvalidArgument;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kDeadlineExceeded;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kNotFound;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kAlreadyExists;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kPermissionDenied;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kUnauthenticated;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kResourceExhausted;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kFailedPrecondition;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kAborted;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kOutOfRange;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kInternal;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kUnavailable;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kDataLoss;
google/cloud/grpc_error_delegate.cc: return google::cloud::StatusCode::kUnknown;
google/cloud/grpc_error_delegate.cc: StatusCode code = StatusCode::kUnknown;
google/cloud/grpc_error_delegate.cc: proto.code() <= static_caststd::int32_t(StatusCode::kUnauthenticated)) {
google/cloud/iam/admin/v1/iam_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc: code = StatusCode::kPermissionDenied;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kDeadlineExceeded;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc: code = StatusCode::kInvalidArgument;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kAborted;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnavailable;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kNotFound;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnknown;
google/cloud/internal/curl_handle.cc: code = StatusCode::kUnavailable;
google/cloud/internal/curl_writev.cc: // These errors are treated as StatusCode::kUnavailable and thus retryable
google/cloud/internal/debug_string_status.cc: case StatusCode::kInvalidArgument:
google/cloud/internal/debug_string_status.cc: case StatusCode::kFailedPrecondition:
google/cloud/internal/debug_string_status.cc: case StatusCode::kOutOfRange:
google/cloud/internal/debug_string_status.cc: case StatusCode::kNotFound:
google/cloud/internal/debug_string_status.cc: case StatusCode::kAlreadyExists:
google/cloud/internal/debug_string_status.cc: case StatusCode::kResourceExhausted:
google/cloud/internal/debug_string_status.cc: case StatusCode::kDataLoss:
google/cloud/internal/debug_string_status.cc: case StatusCode::kUnknown:
google/cloud/internal/debug_string_status.cc: case StatusCode::kInternal:
google/cloud/internal/debug_string_status.cc: case StatusCode::kUnavailable:
google/cloud/internal/debug_string_status.cc: case StatusCode::kDeadlineExceeded:
google/cloud/internal/debug_string_status.cc: case StatusCode::kUnauthenticated: // NOLINT(bugprone-branch-clone)
google/cloud/internal/debug_string_status.cc: case StatusCode::kPermissionDenied:
google/cloud/internal/debug_string_status.cc: case StatusCode::kAborted:
google/cloud/internal/make_status.cc: return Status(StatusCode::kCancelled, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kUnknown, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kInvalidArgument, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kDeadlineExceeded, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kNotFound, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kAlreadyExists, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kPermissionDenied, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kUnauthenticated, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kResourceExhausted, std::move(msg),
google/cloud/internal/make_status.cc: return Status(StatusCode::kFailedPrecondition, std::move(msg),
google/cloud/internal/make_status.cc: return Status(StatusCode::kAborted, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kOutOfRange, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kInternal, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kUnavailable, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kDataLoss, std::move(msg), std::move(info));
google/cloud/internal/make_status.cc: return Status(StatusCode::kCancelled, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kCancelled));
google/cloud/internal/make_status.cc: return Status(StatusCode::kUnknown, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kUnknown));
google/cloud/internal/make_status.cc: return Status(StatusCode::kInvalidArgument, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kInvalidArgument));
google/cloud/internal/make_status.cc: return Status(StatusCode::kDeadlineExceeded, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kDeadlineExceeded));
google/cloud/internal/make_status.cc: return Status(StatusCode::kNotFound, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kNotFound));
google/cloud/internal/make_status.cc: return Status(StatusCode::kAlreadyExists, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kAlreadyExists));
google/cloud/internal/make_status.cc: return Status(StatusCode::kPermissionDenied, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kPermissionDenied));
google/cloud/internal/make_status.cc: return Status(StatusCode::kUnauthenticated, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kUnauthenticated));
google/cloud/internal/make_status.cc: return Status(StatusCode::kResourceExhausted, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kResourceExhausted));
google/cloud/internal/make_status.cc: return Status(StatusCode::kFailedPrecondition, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kFailedPrecondition));
google/cloud/internal/make_status.cc: return Status(StatusCode::kAborted, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kAborted));
google/cloud/internal/make_status.cc: return Status(StatusCode::kOutOfRange, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kOutOfRange));
google/cloud/internal/make_status.cc: return Status(StatusCode::kInternal, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kInternal));
google/cloud/internal/make_status.cc: return Status(StatusCode::kUnavailable, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kUnavailable));
google/cloud/internal/make_status.cc: return Status(StatusCode::kDataLoss, std::move(msg),
google/cloud/internal/make_status.cc: std::move(b).Build(StatusCode::kDataLoss));
google/cloud/internal/oauth2_compute_engine_credentials.cc: status.code() != StatusCode::kUnavailable;
google/cloud/internal/oauth2_compute_engine_credentials.cc: return Status{StatusCode::kInvalidArgument, error_payload, {}};
google/cloud/internal/oauth2_compute_engine_credentials.cc: if ((*response)->StatusCode() == rest_internal::HttpStatusCode::kNotFound) {
google/cloud/internal/opentelemetry.cc: span.SetStatus(opentelemetry::trace::StatusCode::kError, status.message());
google/cloud/internal/rest_response.cc: return StatusCode::kUnknown;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kResumeIncomplete) {
google/cloud/internal/rest_response.cc: return StatusCode::kFailedPrecondition;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kNotModified) {
google/cloud/internal/rest_response.cc: return StatusCode::kFailedPrecondition;
google/cloud/internal/rest_response.cc: return StatusCode::kUnknown;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kBadRequest) {
google/cloud/internal/rest_response.cc: return StatusCode::kInvalidArgument;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kUnauthorized) {
google/cloud/internal/rest_response.cc: return StatusCode::kUnauthenticated;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kForbidden) {
google/cloud/internal/rest_response.cc: return StatusCode::kPermissionDenied;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kNotFound) {
google/cloud/internal/rest_response.cc: return StatusCode::kNotFound;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kMethodNotAllowed) {
google/cloud/internal/rest_response.cc: return StatusCode::kPermissionDenied;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kRequestTimeout) {
google/cloud/internal/rest_response.cc: return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kConflict) {
google/cloud/internal/rest_response.cc: return StatusCode::kAborted;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kGone) {
google/cloud/internal/rest_response.cc: return StatusCode::kNotFound;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kLengthRequired) {
google/cloud/internal/rest_response.cc: return StatusCode::kInvalidArgument;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kPreconditionFailed) {
google/cloud/internal/rest_response.cc: return StatusCode::kFailedPrecondition;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kPayloadTooLarge) {
google/cloud/internal/rest_response.cc: return StatusCode::kOutOfRange;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kRequestRangeNotSatisfiable) {
google/cloud/internal/rest_response.cc: return StatusCode::kOutOfRange;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kTooManyRequests) {
google/cloud/internal/rest_response.cc: return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc: return StatusCode::kInvalidArgument;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kInternalServerError) {
google/cloud/internal/rest_response.cc: return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kBadGateway) {
google/cloud/internal/rest_response.cc: return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc: if (code == HttpStatusCode::kServiceUnavailable) {
google/cloud/internal/rest_response.cc: return StatusCode::kUnavailable;
google/cloud/internal/rest_response.cc: return StatusCode::kInternal;
google/cloud/internal/rest_response.cc: return StatusCode::kUnknown;
google/cloud/internal/rest_response.cc: static_assert(HttpStatusCode::kMinSuccess < HttpStatusCode::kMinNotSuccess,
google/cloud/internal/rest_response.cc: return response.StatusCode() < HttpStatusCode::kMinNotSuccess &&
google/cloud/internal/rest_response.cc: response.StatusCode() >= HttpStatusCode::kMinSuccess;
google/cloud/internal/retry_policy_impl.cc: if (status.code() != StatusCode::kInternal) return false;
google/cloud/internal/streaming_read_rpc.cc: if (status.ok() || status.code() == StatusCode::kCancelled) return;
google/cloud/internal/streaming_write_rpc_impl.cc: if (status.ok() || status.code() == StatusCode::kCancelled) return;
google/cloud/opentelemetry/internal/recordable.cc: if (code == opentelemetry::trace::StatusCode::kUnset) return;
google/cloud/opentelemetry/monitoring_exporter.cc: if (status.code() == StatusCode::kInvalidArgument &&
google/cloud/opentelemetry/monitoring_exporter.cc: } else if (status.code() != StatusCode::kInvalidArgument) {
google/cloud/pubsub/benchmarks/endurance.cc: return google::cloud::Status(google::cloud::StatusCode::kUnknown,
google/cloud/pubsub/benchmarks/throughput.cc: return google::cloud::Status(google::cloud::StatusCode::kUnknown,
google/cloud/pubsub/internal/exactly_once_policies.cc: return (code == StatusCode::kDeadlineExceeded ||
google/cloud/pubsub/internal/exactly_once_policies.cc: code == StatusCode::kResourceExhausted ||
google/cloud/pubsub/internal/exactly_once_policies.cc: code == StatusCode::kAborted || code == StatusCode::kInternal ||
google/cloud/pubsub/internal/exactly_once_policies.cc: code == StatusCode::kUnavailable);
google/cloud/pubsub/samples/schema_samples.cc: if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc: if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc: if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc: if (schema.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/schema_samples.cc: if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (sub.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (snapshot.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/subscription_admin_samples.cc: if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/topic_admin_samples.cc: if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc: if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc: if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc: if (topic.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/pubsub/samples/topic_admin_samples.cc: if (status.code() == google::cloud::StatusCode::kNotFound) {
google/cloud/pubsub/samples/topic_admin_samples.cc: StatusCode::kInvalidArgument);
google/cloud/pubsublite/internal/partition_publisher.cc: StatusCode::kAborted,
google/cloud/resourcemanager/v3/folders_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/resourcemanager/v3/tag_keys_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/resourcemanager/v3/tag_values_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/securitycenter/v1/security_center_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/securitycenter/v2/security_center_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/spanner/admin/database_admin_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/spanner/admin/instance_admin_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc: if (db.status().code() != google::cloud::StatusCode::kUnavailable) break;
google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc: db.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/spanner/benchmarks/single_row_throughput_benchmark.cc: if (db.status().code() != google::cloud::StatusCode::kUnavailable) break;
google/cloud/spanner/benchmarks/single_row_throughput_benchmark.cc: db.status().code() == google::cloud::StatusCode::kAlreadyExists) {
google/cloud/spanner/internal/partial_result_set_source.cc: if (!status.ok() && status.code() != StatusCode::kCancelled) {
google/cloud/spanner/internal/partial_result_set_source.cc: return Status(StatusCode::kInternal,
google/cloud/spanner/internal/partial_result_set_source.cc: return Status(StatusCode::kInternal,
google/cloud/spanner/internal/status_utils.cc: if (status.code() != StatusCode::kNotFound) return false;
google/cloud/spanner/numeric.cc: return Status(StatusCode::kOutOfRange, std::move(message));
google/cloud/spanner/numeric.cc: return Status(StatusCode::kDataLoss, std::move(message));
google/cloud/spanner/samples/postgresql_samples.cc: google::cloud::StatusCode::kUnknown,
google/cloud/spanner/samples/samples.cc: google::cloud::StatusCode::kNotFound) {
google/cloud/spanner/samples/samples.cc: google::cloud::StatusCode::kAborted) {
google/cloud/spanner/samples/samples.cc: google::cloud::StatusCode::kUnknown,
google/cloud/spanner/samples/samples.cc: if (status.code() != google::cloud::StatusCode::kFailedPrecondition ||
google/cloud/spanner/testing/pick_random_instance.cc: if (instance || instance.status().code() == StatusCode::kAlreadyExists) {
google/cloud/spanner/timestamp.cc: return Status(StatusCode::kInvalidArgument, std::move(message));
google/cloud/spanner/value.cc: return Status(StatusCode::kUnknown,
google/cloud/status.cc: case StatusCode::kCancelled:
google/cloud/status.cc: case StatusCode::kUnknown:
google/cloud/status.cc: case StatusCode::kInvalidArgument:
google/cloud/status.cc: case StatusCode::kDeadlineExceeded:
google/cloud/status.cc: case StatusCode::kNotFound:
google/cloud/status.cc: case StatusCode::kAlreadyExists:
google/cloud/status.cc: case StatusCode::kPermissionDenied:
google/cloud/status.cc: case StatusCode::kUnauthenticated:
google/cloud/status.cc: case StatusCode::kResourceExhausted:
google/cloud/status.cc: case StatusCode::kFailedPrecondition:
google/cloud/status.cc: case StatusCode::kAborted:
google/cloud/status.cc: case StatusCode::kOutOfRange:
google/cloud/status.cc: case StatusCode::kInternal:
google/cloud/status.cc: case StatusCode::kUnavailable:
google/cloud/status.cc: case StatusCode::kDataLoss:
google/cloud/storage/examples/storage_client_mock_samples.cc: google::cloud::StatusCode::kInvalidArgument,
google/cloud/storage/examples/storage_client_mock_samples.cc: google::cloud::StatusCode::kInvalidArgument, "Invalid Argument"}));
google/cloud/storage/examples/storage_object_resumable_write_samples.cc: if (!status.ok() && status.code() != google::cloud::StatusCode::kNotFound) {
google/cloud/storage/internal/connection_impl.cc: if (status.code() == StatusCode::kAborted &&
google/cloud/storage/internal/grpc/object_read_source.cc: result.response.status_code = storage::internal::HttpStatusCode::kContinue;
google/cloud/storage/internal/grpc/stub.cc: if (code == StatusCode::kFailedPrecondition || code == StatusCode::kAborted) {
google/cloud/storage/internal/grpc/stub.cc: if (patch.status().code() == StatusCode::kFailedPrecondition) {
google/cloud/storage/internal/grpc/stub.cc: if (patch.status().code() == StatusCode::kFailedPrecondition) {
google/cloud/storage/internal/grpc/stub.cc: if (patch.status().code() == StatusCode::kFailedPrecondition) {
google/cloud/storage/internal/http_response.cc: if (code < 0 || code > 600) return StatusCode::kUnknown;
google/cloud/storage/internal/object_requests.cc: response.status_code == HttpStatusCode::kCreated;
google/cloud/storage/internal/rest/object_read_source.cc: h.status_code = HttpStatusCode::kContinue;
google/cloud/storage/internal/rest/stub.cc: if (!response && response.status().code() == StatusCode::kAborted) {
google/cloud/storage/internal/rest/stub.cc: return (code != rest::HttpStatusCode::kResumeIncomplete &&
google/cloud/storage/internal/rest/stub.cc: code >= rest::HttpStatusCode::kMinNotSuccess);
google/cloud/storage/internal/rest/stub.cc: return (code != rest::HttpStatusCode::kClientClosedRequest &&
google/cloud/storage/internal/rest/stub.cc: code >= rest::HttpStatusCode::kMinNotSuccess);
google/cloud/storage/internal/rest/stub.cc: return (code != rest::HttpStatusCode::kResumeIncomplete &&
google/cloud/storage/internal/rest/stub.cc: code >= rest::HttpStatusCode::kMinNotSuccess);
google/cloud/storage/internal/retry_object_read_source.cc: if (result->response.status_code != HttpStatusCode::kContinue &&
google/cloud/tasks/v2/cloud_tasks_client.cc: if (result || result.status().code() != StatusCode::kAborted ||
google/cloud/testing_util/opentelemetry_matchers.cc: case opentelemetry::trace::StatusCode::kError:
google/cloud/testing_util/opentelemetry_matchers.cc: case opentelemetry::trace::StatusCode::kUnset:

@alevenberg alevenberg mentioned this issue May 13, 2024
Merged
This was referenced May 13, 2024
Merged
Merged
Merged
Merged
@alevenberg
Copy link
Member Author

The rest of the PRs should have covered everything. Can close after they are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alevenberg alevenberg

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coryan @alevenberg