Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use Status factory functions #14221

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented May 10, 2024

#14107


This change is Reviewable

@alevenberg alevenberg marked this pull request as ready for review May 10, 2024 18:54
@alevenberg alevenberg requested a review from a team as a code owner May 10, 2024 18:54
@alevenberg alevenberg enabled auto-merge (squash) May 10, 2024 18:55
@coryan coryan disabled auto-merge May 10, 2024 19:00
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 67.77778% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 93.79%. Comparing base (bd6390c) to head (cb78c1f).
Report is 7 commits behind head on main.

Files Patch % Lines
google/cloud/internal/openssl/sign_using_sha256.cc 14.28% 24 Missing ⚠️
...internal/openssl/parse_service_account_p12_file.cc 33.33% 4 Missing ⚠️
...cloud/internal/grpc_impersonate_service_account.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14221      +/-   ##
==========================================
+ Coverage   93.24%   93.79%   +0.54%     
==========================================
  Files        2206     2293      +87     
  Lines      192142   202934   +10792     
==========================================
+ Hits       179156   190332   +11176     
+ Misses      12986    12602     -384     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit a42154b into googleapis:main May 13, 2024
63 checks passed
@alevenberg alevenberg deleted the internal branch May 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants