Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(bigtable): use Status factory functions #14223

Merged
merged 4 commits into from May 13, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented May 10, 2024

#14107


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 10, 2024
@alevenberg alevenberg marked this pull request as ready for review May 13, 2024 16:23
@alevenberg alevenberg requested a review from a team as a code owner May 13, 2024 16:23
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.24%. Comparing base (bcfae5d) to head (933887c).
Report is 11 commits behind head on main.

Files Patch % Lines
google/cloud/bigtable/benchmarks/benchmark.cc 0.00% 2 Missing ⚠️
...le/cloud/bigtable/internal/data_connection_impl.cc 0.00% 2 Missing ⚠️
google/cloud/bigtable/table.cc 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14223      +/-   ##
==========================================
- Coverage   93.79%   93.24%   -0.56%     
==========================================
  Files        2295     2208      -87     
  Lines      202974   192207   -10767     
==========================================
- Hits       190385   179214   -11171     
- Misses      12589    12993     +404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit 0b1549b into googleapis:main May 13, 2024
63 checks passed
@alevenberg alevenberg deleted the bt branch May 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants