Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(generator): use Status factory functions #14220

Merged
merged 2 commits into from May 13, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented May 10, 2024

#14107


This change is Reviewable

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.23%. Comparing base (bd6390c) to head (b0c5d32).
Report is 5 commits behind head on main.

Files Patch % Lines
generator/internal/service_code_generator.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14220      +/-   ##
==========================================
- Coverage   93.24%   93.23%   -0.01%     
==========================================
  Files        2206     2206              
  Lines      192142   192146       +4     
==========================================
- Hits       179156   179154       -2     
- Misses      12986    12992       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg marked this pull request as ready for review May 10, 2024 18:55
@alevenberg alevenberg requested a review from a team as a code owner May 10, 2024 18:55
@alevenberg alevenberg merged commit fb2b8b8 into googleapis:main May 13, 2024
63 checks passed
@alevenberg alevenberg deleted the generator branch May 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants