Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DLQ for all ingest consumers #67349

Merged
merged 1 commit into from Mar 21, 2024
Merged

feat: DLQ for all ingest consumers #67349

merged 1 commit into from Mar 21, 2024

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Mar 20, 2024

Failed attachments and transactions, and user feedback messages now get dlq'ed

@lynnagara lynnagara requested review from untitaker, fpacifici and a team March 20, 2024 16:52
@lynnagara lynnagara requested review from a team as code owners March 20, 2024 16:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (74ac372) to head (7227a92).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #67349      +/-   ##
==========================================
- Coverage   84.33%   84.33%   -0.01%     
==========================================
  Files        5309     5309              
  Lines      237239   237235       -4     
  Branches    41031    41031              
==========================================
- Hits       200079   200074       -5     
- Misses      36942    36943       +1     
  Partials      218      218              
Files Coverage Δ
src/sentry/consumers/__init__.py 76.74% <ø> (ø)
src/sentry/ingest/consumer/simple_event.py 87.09% <ø> (-1.48%) ⬇️

... and 5 files with indirect coverage changes

@lynnagara lynnagara changed the title feat: DLQ for ingest-transactions and ingest-attachments feat: DLQ for all ingest consumers Mar 20, 2024
@lynnagara lynnagara merged commit 2458817 into master Mar 21, 2024
53 checks passed
@lynnagara lynnagara deleted the ingest-dlqs branch March 21, 2024 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants