Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest+feedback): modify ingest strategy to use the feedback DLQ #67394

Closed
wants to merge 3 commits into from

Conversation

aliu3ntry
Copy link
Member

  • also renames the feedback consumer type and uses the enum more

- also rename the feedback consumer type and use the enum more
@aliu3ntry aliu3ntry requested review from a team as code owners March 20, 2024 22:44
@aliu3ntry aliu3ntry requested a review from a team March 20, 2024 22:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (7e9c87e) to head (1530a5f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #67394       +/-   ##
===========================================
+ Coverage   53.47%   79.37%   +25.89%     
===========================================
  Files        5384     6364      +980     
  Lines      225990   281952    +55962     
  Branches    38733    48518     +9785     
===========================================
+ Hits       120856   223789   +102933     
+ Misses     104772    57800    -46972     
- Partials      362      363        +1     
Files Coverage Δ
src/sentry/consumers/__init__.py 76.92% <100.00%> (ø)
src/sentry/ingest/consumer/simple_event.py 81.57% <100.00%> (ø)
src/sentry/ingest/types.py 100.00% <100.00%> (ø)

... and 2208 files with indirect coverage changes

@lynnagara
Copy link
Member

I think this is in conflict with how it's done in #67349

@aliu3ntry
Copy link
Member Author

aliu3ntry commented Mar 20, 2024

I think this is in conflict with how it's done in #67349

Oh, looks like you're just removing the check entirely? Yeah looks like that one's not merged yet, how do you want to go about combining these @lynnagara ?

@lynnagara
Copy link
Member

lynnagara commented Mar 20, 2024

The other PR also takes care of user feedback (updated the description to reflect that), so personally i'd prefer to just merge that one

@aliu3ntry
Copy link
Member Author

true, i'll just close this then

@aliu3ntry aliu3ntry closed this Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants