feat(feedback): use ConsumerType in consumer defns + rename feedback c.type

[aliu3ntry]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (95f6ff1) to head (50f9370).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #67404      +/-   ##
==========================================
+ Coverage   78.37%   79.36%   +0.98%     
==========================================
  Files        6365     6365              
  Lines      281981   281923      -58     
  Branches    48516    48507       -9     
==========================================
+ Hits       221009   223741    +2732     
+ Misses      60607    57819    -2788     
+ Partials      365      363       -2     

Files	Coverage Δ
src/sentry/consumers/__init__.py	76.92% <100.00%> (+0.17%)	⬆️
src/sentry/ingest/types.py	100.00% <100.00%> (ø)

... and 253 files with indirect coverage changes

[lynnagara]

Curious if you have any plan to split the factory? Longer term I think it'd be better for each ingest consumer to have it's own factory instead of a single pretty huge piece of code that has a bunch of if statements inside it that need to check the consumer type. Since transactions is going away, only attachments, user feedback and events would need to be done.

[aliu3ntry]

Curious if you have any plan to split the factory? Longer term I think it'd be better for each ingest consumer to have it's own factory instead of a single pretty huge piece of code that has a bunch of if statements inside it that need to check the consumer type. Since transactions is going away, only attachments, user feedback and events would need to be done.

I was thinking about this actually, will get back to you. That will probably be a separate PR though