Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feedback): add config for feedback DLQ #67068

Merged
merged 4 commits into from Mar 15, 2024
Merged

feat(feedback): add config for feedback DLQ #67068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c88f65
feat(feedback): add config for feedback DLQ
aliu3ntry Mar 15, 2024
c38aa4c
remove dlq_max_ fields
aliu3ntry Mar 15, 2024
9206e54
remove ingest-events[-dlq] from unregistered topics
aliu3ntry Mar 15, 2024
cf07413
Merge branch 'master' into aliu/config-feedback-dlq
aliu3ntry Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/conf/server.py
View file
Open in desktop
Expand Up @@ -3473,6 +3473,7 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str]
"metrics-subscription-results": "default",
"ingest-events": "default",
"ingest-feedback-events": "default",
"ingest-feedback-events-dlq": "default",
"ingest-attachments": "default",
"ingest-transactions": "default",
"ingest-metrics": "default",
Expand Down
1 change: 1 addition & 0 deletions src/sentry/conf/types/kafka_definition.py
View file
Open in desktop
Expand Up @@ -27,6 +27,7 @@ class Topic(Enum):
INGEST_EVENTS = "ingest-events"
INGEST_EVENTS_DLQ = "ingest-events-dlq"
INGEST_FEEDBACK_EVENTS = "ingest-feedback-events"
INGEST_FEEDBACK_EVENTS_DLQ = "ingest-feedback-events-dlq"
INGEST_ATTACHMENTS = "ingest-attachments"
INGEST_TRANSACTIONS = "ingest-transactions"
INGEST_METRICS = "ingest-metrics"
Expand Down
1 change: 1 addition & 0 deletions src/sentry/consumers/__init__.py
View file
Open in desktop
Expand Up @@ -268,6 +268,7 @@ def ingest_events_options() -> list[click.Option]:
"static_args": {
"consumer_type": "feedback-events",
},
"dlq_topic": Topic.INGEST_FEEDBACK_EVENTS_DLQ,
},
"ingest-attachments": {
"topic": Topic.INGEST_ATTACHMENTS,
Expand Down
2 changes: 0 additions & 2 deletions tests/sentry/conf/test_kafka_definition.py
View file
Open in desktop
Expand Up @@ -16,8 +16,6 @@ def test_topic_definition() -> None:
# TODO: Remove this once these topics are actually registered in sentry-kafka-schemas
currently_unregistered_topics = [
"outcomes-billing",
"ingest-events",
"ingest-events-dlq",
Comment on lines -19 to -20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

"ingest-attachments",
"ingest-transactions",
"ingest-metrics-dlq",
Expand Down