ref: Remove references to deprecated settings #66532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settings.KAFKA_INGEST_PERFORMANCE_METRICS and settings.KAFKA_INGEST_METRICS are deprecated.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66532 +/- ##
=======================================
Coverage 84.30% 84.31%
=======================================
Files 5311 5311
Lines 237358 237421 +63
Branches 41058 41075 +17
=======================================
+ Hits 200107 200170 +63
Misses 37032 37032
Partials 219 219
|
lynnagara
commented
Mar 7, 2024
| @@ -116,8 +113,7 @@ def get_ingest_config( | |||
| MetricsIngestConfiguration( | |||
| db_backend=IndexerStorage.MOCK, | |||
| db_backend_options={}, | |||
| input_topic="topic", | |||
| output_topic="output-topic", | |||
| output_topic=Topic.SNUBA_METRICS, | |||
There was a problem hiding this comment.
This type was wrong, it's only used in tests though
There was a problem hiding this comment.
it's on the excluded from checking list 😆
JoshFerge
approved these changes
Mar 7, 2024
fpacifici
approved these changes
Mar 7, 2024
| @@ -116,8 +113,7 @@ def get_ingest_config( | |||
| MetricsIngestConfiguration( | |||
| db_backend=IndexerStorage.MOCK, | |||
| db_backend_options={}, | |||
| input_topic="topic", | |||
| output_topic="output-topic", | |||
| output_topic=Topic.SNUBA_METRICS, | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings.KAFKA_INGEST_PERFORMANCE_METRICS and settings.KAFKA_INGEST_METRICS are deprecated.
The IngestConfiguration.input_topic was never used anywhere.