Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Remove references to deprecated settings #66532

Merged
merged 2 commits into from Mar 7, 2024
Merged

ref: Remove references to deprecated settings #66532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fcdc04
ref: Remove references to deprecated settings
lynnagara Mar 7, 2024
2c297bf
revert change
lynnagara Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/sentry/sentry_metrics/configuration.py
View file
Open in desktop
Expand Up @@ -47,7 +47,6 @@ class IndexerStorage(Enum):
class MetricsIngestConfiguration:
db_backend: IndexerStorage
db_backend_options: Mapping[str, Any]
input_topic: str
output_topic: Topic
use_case_id: UseCaseKey
internal_metrics_tag: str | None
Expand Down Expand Up @@ -80,7 +79,6 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.POSTGRES,
db_backend_options={},
input_topic=settings.KAFKA_INGEST_METRICS,
output_topic=Topic.SNUBA_METRICS,
use_case_id=UseCaseKey.RELEASE_HEALTH,
internal_metrics_tag="release-health",
Expand All @@ -97,7 +95,6 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.POSTGRES,
db_backend_options={},
input_topic=settings.KAFKA_INGEST_PERFORMANCE_METRICS,
output_topic=Topic.SNUBA_GENERIC_METRICS,
use_case_id=UseCaseKey.PERFORMANCE,
internal_metrics_tag="perf",
Expand All @@ -116,8 +113,7 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.MOCK,
db_backend_options={},
input_topic="topic",
output_topic="output-topic",
output_topic=Topic.SNUBA_METRICS,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type was wrong, it's only used in tests though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did it pass mypy ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's on the excluded from checking list 😆

use_case_id=use_case_key,
internal_metrics_tag="release-health",
writes_limiter_cluster_options={},
Expand All @@ -134,8 +130,7 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.MOCK,
db_backend_options={},
input_topic="topic",
output_topic="output-topic",
output_topic=Topic.SNUBA_GENERIC_METRICS,
use_case_id=use_case_key,
internal_metrics_tag="perf",
writes_limiter_cluster_options={},
Expand Down