Skip to content

Commit

Permalink
ref: Remove references to deprecated settings (#66532)
Browse files Browse the repository at this point in the history
settings.KAFKA_INGEST_PERFORMANCE_METRICS and
settings.KAFKA_INGEST_METRICS are deprecated.

The IngestConfiguration.input_topic was never used anywhere.
  • Loading branch information
lynnagara committed Mar 7, 2024
1 parent 4e688a2 commit db0aa94
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/sentry/sentry_metrics/configuration.py
Expand Up @@ -47,7 +47,6 @@ class IndexerStorage(Enum):
class MetricsIngestConfiguration:
db_backend: IndexerStorage
db_backend_options: Mapping[str, Any]
input_topic: str
output_topic: Topic
use_case_id: UseCaseKey
internal_metrics_tag: str | None
Expand Down Expand Up @@ -80,7 +79,6 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.POSTGRES,
db_backend_options={},
input_topic=settings.KAFKA_INGEST_METRICS,
output_topic=Topic.SNUBA_METRICS,
use_case_id=UseCaseKey.RELEASE_HEALTH,
internal_metrics_tag="release-health",
Expand All @@ -97,7 +95,6 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.POSTGRES,
db_backend_options={},
input_topic=settings.KAFKA_INGEST_PERFORMANCE_METRICS,
output_topic=Topic.SNUBA_GENERIC_METRICS,
use_case_id=UseCaseKey.PERFORMANCE,
internal_metrics_tag="perf",
Expand All @@ -116,8 +113,7 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.MOCK,
db_backend_options={},
input_topic="topic",
output_topic="output-topic",
output_topic=Topic.SNUBA_METRICS,
use_case_id=use_case_key,
internal_metrics_tag="release-health",
writes_limiter_cluster_options={},
Expand All @@ -134,8 +130,7 @@ def get_ingest_config(
MetricsIngestConfiguration(
db_backend=IndexerStorage.MOCK,
db_backend_options={},
input_topic="topic",
output_topic="output-topic",
output_topic=Topic.SNUBA_GENERIC_METRICS,
use_case_id=use_case_key,
internal_metrics_tag="perf",
writes_limiter_cluster_options={},
Expand Down

0 comments on commit db0aa94

Please sign in to comment.