Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): add config for new topic ingest-feedback-events #66484

Merged
merged 10 commits into from Mar 13, 2024

Conversation

aliu3ntry
Copy link
Member

@aliu3ntry aliu3ntry commented Mar 6, 2024

@aliu3ntry aliu3ntry requested a review from a team as a code owner March 6, 2024 23:27
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 6, 2024
@aliu3ntry aliu3ntry requested review from lynnagara and a team March 6, 2024 23:31
@aliu3ntry aliu3ntry requested a review from a team as a code owner March 6, 2024 23:35
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (8c4ea26) to head (909bdcc).

❗ Current head 909bdcc differs from pull request most recent head a618c32. Consider uploading reports for the commit a618c32 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #66484       +/-   ##
===========================================
+ Coverage   53.62%   84.31%   +30.68%     
===========================================
  Files        4333     5308      +975     
  Lines      181356   237306    +55950     
  Branches    31252    41041     +9789     
===========================================
+ Hits        97261   200075   +102814     
+ Misses      83878    37013    -46865     
- Partials      217      218        +1     
Files Coverage Δ
src/sentry/conf/server.py 89.61% <ø> (ø)
src/sentry/conf/types/kafka_definition.py 100.00% <100.00%> (+3.77%) ⬆️
src/sentry/consumers/__init__.py 76.74% <ø> (ø)
src/sentry/ingest/types.py 100.00% <100.00%> (ø)

... and 2204 files with indirect coverage changes

src/sentry/consumers/__init__.py Show resolved Hide resolved
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliu3ntry aliu3ntry dismissed cmanallen’s stale review March 13, 2024 17:43

change made in "use Topic enum" (it's very small)

@aliu3ntry aliu3ntry enabled auto-merge (squash) March 13, 2024 17:44
@aliu3ntry aliu3ntry merged commit 9ab40c3 into master Mar 13, 2024
48 checks passed
@aliu3ntry aliu3ntry deleted the aliu/ingest-feedback-events-config branch March 13, 2024 18:08
aliu3ntry added a commit that referenced this pull request Mar 20, 2024
Adding a new topic to sentry local devservers. This is yet to be tested
in prod, currently feedbacks are still ingested through ingest-events.
See #66484
oioki pushed a commit that referenced this pull request Mar 21, 2024
Adding a new topic to sentry local devservers. This is yet to be tested
in prod, currently feedbacks are still ingested through ingest-events.
See #66484
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants