New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): add config for new topic ingest-feedback-events #66484
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66484 +/- ##
===========================================
+ Coverage 53.62% 84.31% +30.68%
===========================================
Files 4333 5308 +975
Lines 181356 237306 +55950
Branches 31252 41041 +9789
===========================================
+ Hits 97261 200075 +102814
+ Misses 83878 37013 -46865
- Partials 217 218 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
change made in "use Topic enum" (it's very small)
Adding a new topic to sentry local devservers. This is yet to be tested in prod, currently feedbacks are still ingested through ingest-events. See #66484
Adding a new topic to sentry local devservers. This is yet to be tested in prod, currently feedbacks are still ingested through ingest-events. See #66484
Linked to #66100 and
https://getsentry.atlassian.net/browse/OPS-5317
Dependent on:
sentry-kafka-schemas PR