Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner): add ingest-feedback-events topic to devserver #67364

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

aliu3ntry
Copy link
Member

Adding a new topic to sentry local devservers. This is yet to be tested in prod, currently feedbacks are still ingested through ingest-events. See #66484

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 20, 2024
@aliu3ntry aliu3ntry requested review from a team, billyvg, Jesse-Box, Lms24, c298lee, michellewzhang, angelajiang13 and bmckerry and removed request for a team March 20, 2024 19:23
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (963102b) to head (42d1f98).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #67364      +/-   ##
==========================================
+ Coverage   83.19%   84.34%   +1.14%     
==========================================
  Files        5313     5314       +1     
  Lines      237289   237309      +20     
  Branches    41034    41037       +3     
==========================================
+ Hits       197420   200148    +2728     
+ Misses      39651    36943    -2708     
  Partials      218      218              

see 227 files with indirect coverage changes

@aliu3ntry aliu3ntry merged commit 551af0d into master Mar 20, 2024
52 checks passed
@aliu3ntry aliu3ntry deleted the aliu/test-feedback-consumer branch March 20, 2024 20:35
oioki pushed a commit that referenced this pull request Mar 21, 2024
Adding a new topic to sentry local devservers. This is yet to be tested
in prod, currently feedbacks are still ingested through ingest-events.
See #66484
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants