Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): add config for new topic ingest-feedback-events #66484

Merged
merged 10 commits into from
Mar 13, 2024
1 change: 1 addition & 0 deletions src/sentry/conf/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -3496,6 +3496,7 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str]
"sessions-subscription-results": "default",
"metrics-subscription-results": "default",
"ingest-events": "default",
"ingest-feedback-events": "default",
"ingest-attachments": "default",
"ingest-transactions": "default",
"ingest-metrics": "default",
Expand Down
1 change: 1 addition & 0 deletions src/sentry/conf/types/kafka_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class Topic(Enum):
METRICS_SUBSCRIPTIONS_RESULTS = "metrics-subscription-results"
INGEST_EVENTS = "ingest-events"
INGEST_EVENTS_DLQ = "ingest-events-dlq"
INGEST_FEEDBACK_EVENTS = "ingest-feedback-events"
INGEST_ATTACHMENTS = "ingest-attachments"
INGEST_TRANSACTIONS = "ingest-transactions"
INGEST_METRICS = "ingest-metrics"
Expand Down
8 changes: 8 additions & 0 deletions src/sentry/consumers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,14 @@ def ingest_events_options() -> list[click.Option]:
"consumer_type": "events",
},
},
"ingest-feedback-events": {
"topic": Topic.INGEST_FEEDBACK_EVENTS,
"strategy_factory": "sentry.ingest.consumer.factory.IngestStrategyFactory",
"click_options": ingest_events_options(),
"static_args": {
"consumer_type": "feedback-events",
},
},
"ingest-attachments": {
"topic": Topic.INGEST_ATTACHMENTS,
aliu3ntry marked this conversation as resolved.
Show resolved Hide resolved
"strategy_factory": "sentry.ingest.consumer.factory.IngestStrategyFactory",
Expand Down
1 change: 1 addition & 0 deletions src/sentry/ingest/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ class ConsumerType:
Events = "events" # consumes simple events ( from the Events topic)
Attachments = "attachments" # consumes events with attachments ( from the Attachments topic)
Transactions = "transactions" # consumes transaction events ( from the Transactions topic)
FeedbackEvents = "feedback-events" # consumes user feedback events ( from the Feedbacks topic)