New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Add Mobile Replay Alpha #3714
Draft
krystofwoldrich
wants to merge
57
commits into
feat/replay
Choose a base branch
from
kw-add-replay-v0
base: feat/replay
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0db0c72+dirty | 1275.02 ms | 1285.84 ms | 10.82 ms |
9433f35+dirty | 1246.94 ms | 1271.45 ms | 24.52 ms |
76d1baf+dirty | 1244.10 ms | 1268.52 ms | 24.42 ms |
e2b64fe+dirty | 1232.22 ms | 1255.20 ms | 22.98 ms |
8900e1a+dirty | 1210.27 ms | 1218.66 ms | 8.39 ms |
e73f4ed+dirty | 1243.27 ms | 1244.52 ms | 1.25 ms |
3853f43+dirty | 1221.82 ms | 1242.64 ms | 20.82 ms |
27ef4ee+dirty | 1293.52 ms | 1296.08 ms | 2.56 ms |
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
22e31b6+dirty | 1253.62 ms | 1265.96 ms | 12.34 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0db0c72+dirty | 2.36 MiB | 2.84 MiB | 487.01 KiB |
9433f35+dirty | 2.36 MiB | 2.85 MiB | 499.80 KiB |
76d1baf+dirty | 2.36 MiB | 2.82 MiB | 469.45 KiB |
e2b64fe+dirty | 2.36 MiB | 2.85 MiB | 495.80 KiB |
8900e1a+dirty | 2.36 MiB | 2.83 MiB | 479.25 KiB |
e73f4ed+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
3853f43+dirty | 2.36 MiB | 2.85 MiB | 499.81 KiB |
27ef4ee+dirty | 2.36 MiB | 2.85 MiB | 500.03 KiB |
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
22e31b6+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0db0c72+dirty | 1258.88 ms | 1262.52 ms | 3.64 ms |
9433f35+dirty | 1232.24 ms | 1232.74 ms | 0.50 ms |
76d1baf+dirty | 1245.00 ms | 1257.76 ms | 12.76 ms |
e2b64fe+dirty | 1285.78 ms | 1297.56 ms | 11.78 ms |
8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
e73f4ed+dirty | 1282.90 ms | 1309.30 ms | 26.40 ms |
3853f43+dirty | 1271.74 ms | 1278.04 ms | 6.30 ms |
27ef4ee+dirty | 1236.41 ms | 1244.90 ms | 8.49 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
22e31b6+dirty | 1276.55 ms | 1278.12 ms | 1.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0db0c72+dirty | 2.92 MiB | 3.40 MiB | 492.71 KiB |
9433f35+dirty | 2.92 MiB | 3.41 MiB | 503.55 KiB |
76d1baf+dirty | 2.92 MiB | 3.38 MiB | 475.74 KiB |
e2b64fe+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
e73f4ed+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
3853f43+dirty | 2.92 MiB | 3.41 MiB | 503.54 KiB |
27ef4ee+dirty | 2.92 MiB | 3.41 MiB | 503.72 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
22e31b6+dirty | 2.92 MiB | 3.43 MiB | 524.74 KiB |
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
This was referenced Apr 24, 2024
krystofwoldrich
changed the title
Add Mobile Replay
feat(replay): Add Mobile Replay Alpha.0
Apr 30, 2024
|
Missing:
|
Co-authored-by: GitHub <noreply@github.com>
* fix(ci): Pin perf metrics ios builds to macos-14 and xcode 14 * Update e2e.yml
* feat(ReactNativeClientOptions): Remove "tunnel" option Remove the "tunnel" option from the ReactNativeClientOptions type due to lack of support in React Native. * fix build * add changelog * fix link * fix lint --------- Co-authored-by: AliReza <38973917+AliReza99@users.noreply.github.com>
Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: GitHub <noreply@github.com>
krystofwoldrich
changed the title
feat(replay): Add Mobile Replay Alpha.0
feat(replay): Add Mobile Replay Alpha
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Todo
replayId
on the Scope (or anywhere else accessible by the Hybrid SDKs)_experimental
optionmaskAll
bool flagLater
Blocking for
alpha.0
releasecaptureReplay
without Event param for Hybrid SDKs sentry-cocoa#3878sendReplay
method for Hybrid SDKs sentry-java#3383💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled