Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Add sendReplay method for Hybrid SDKs #3383

Merged

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Apr 23, 2024

#skip-changelog

馃摐 Description

This PR adds sendReplay method which is not depending on the Event class and so can be used by the hybrid SDKs to capture Replay for hybrid errors (JS errors).

馃挕 Motivation and Context

馃挌 How did you test it?

Tested with the RN Sample app.

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@krystofwoldrich krystofwoldrich changed the title feat(replay): Add sendReplay method for Hybrid SDKs [SR] Add sendReplay method for Hybrid SDKs Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 386.76 ms 483.21 ms 96.46 ms
Size 1.70 MiB 2.32 MiB 635.46 KiB

Baseline results on branch: rz/feat/session-replay-network-requests

Startup times

Revision Plain With Sentry Diff
331bc76 425.82 ms 504.04 ms 78.22 ms

App size

Revision Plain With Sentry Diff
331bc76 1.70 MiB 2.32 MiB 635.66 KiB

Previous results on branch: kw/feat/session-replay-send-replay-for-hybrids

Startup times

Revision Plain With Sentry Diff
842fc3c 401.36 ms 479.80 ms 78.44 ms

App size

Revision Plain With Sentry Diff
842fc3c 1.70 MiB 2.32 MiB 635.46 KiB

Base automatically changed from rz/feat/session-replay-network-requests to rz/feat/session-replay April 25, 2024 10:20
@romtsn romtsn merged commit 9295f0f into rz/feat/session-replay Apr 25, 2024
19 of 23 checks passed
@romtsn romtsn deleted the kw/feat/session-replay-send-replay-for-hybrids branch April 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants