New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): add captureReplay
without Event param for Hybrid SDKs
#3878
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3878 +/- ##
=============================================
- Coverage 90.635% 90.609% -0.026%
=============================================
Files 579 579
Lines 45298 45313 +15
Branches 16122 16124 +2
=============================================
+ Hits 41056 41058 +2
- Misses 4063 4076 +13
Partials 179 179
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure about exposing SentrySessionReplay to Hybrid SDK.
And btw, I plan to migrate this to swift.
What are the benefits of this instead of a start//stopReplay
function at PrivateSentrySDKOnly
?
@brustolin I tried to make minimum changes to get Replay working for RN as I know you are planning to change this class. I opened this PR to establish an interface in |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b9a9dca | 1377.00 ms | 1382.55 ms | 5.55 ms |
da5462e | 1198.18 ms | 1229.14 ms | 30.96 ms |
f8833c4 | 1230.00 ms | 1245.27 ms | 15.27 ms |
8f397a7 | 1251.82 ms | 1268.34 ms | 16.52 ms |
7fb7afb | 1230.12 ms | 1251.04 ms | 20.92 ms |
289c0b8 | 1245.63 ms | 1253.76 ms | 8.13 ms |
6c31077 | 1233.80 ms | 1245.34 ms | 11.54 ms |
b483671 | 1217.20 ms | 1236.82 ms | 19.62 ms |
fc163f5 | 1219.18 ms | 1242.74 ms | 23.56 ms |
154f795 | 1225.53 ms | 1231.04 ms | 5.51 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b9a9dca | 21.58 KiB | 414.59 KiB | 393.01 KiB |
da5462e | 22.85 KiB | 412.98 KiB | 390.13 KiB |
f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
289c0b8 | 22.85 KiB | 407.67 KiB | 384.82 KiB |
6c31077 | 22.84 KiB | 401.65 KiB | 378.81 KiB |
b483671 | 20.76 KiB | 434.72 KiB | 413.96 KiB |
fc163f5 | 20.76 KiB | 436.29 KiB | 415.53 KiB |
154f795 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
This PR splits
captureReplayForEvent
intocaptureReplay
andcaptureReplayForEvent
, as Hybrid SDKs need to capture replay without passing their event to native.This PR is need for the
alpha.0
of RN replay.#skip-changelog