-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 : FIX : Long labels overflowing in extended navigation rail. #145474
Merged
auto-submit
merged 58 commits into
flutter:master
from
aliasgar4558:Code/Fix/label_overflow_in_extended_rail
May 8, 2024
Merged
Changes from 56 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
fa4fca9
🐛 : FIX : Long labels overflowing in extended navigation rail.
aliasgar4558 1156c28
Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende…
aliasgar4558 156694f
Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 b728a46
Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 da1d802
Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 b223d7e
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 0f5b16a
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 a376245
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 71978c2
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 8a6d5d9
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 aab3962
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 cc17e01
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 9ec4d7c
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 058dbb9
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 17d4f91
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 4c523e1
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 98a639a
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 f31daa8
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 a7e9735
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 4725df8
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 e581bf9
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 251effd
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 7f4e863
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 515e110
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 c65a9e5
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 0c342f7
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 2b34357
🎨 : Expanded replaced with "Flexible" to prevent overflow bounds.
aliasgar4558 c997a9b
✅ : Tightly coupled test case added.
aliasgar4558 a503388
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 b8eeb27
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 b74bf0d
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 861a377
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 240e99b
Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 a461ec6
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 50e261d
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 7d91e6b
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 affc19b
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 0955bb4
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 bb3f8af
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 0963364
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 bb277b2
Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende…
aliasgar4558 abbf860
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 0b5803f
✅ : Test case updated to determine the Nav. destination's height on w…
aliasgar4558 0e2381e
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 11a2bce
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 a95116a
Apply suggestions from code review
aliasgar4558 833c979
Update packages/flutter/test/material/navigation_rail_test.dart
aliasgar4558 b92a815
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 db66288
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 f784461
Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 9f88074
💡 : PR comments & suggestions resolved for test case.
aliasgar4558 1398cfe
Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende…
aliasgar4558 0082afe
Merge branch 'Code/Fix/label_overflow_in_extended_rail' into Code/Fix…
aliasgar4558 d6458a8
Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende…
aliasgar4558 908ee43
Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 f0bd607
Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 ecf9a3f
Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail
aliasgar4558 1205c75
♻️ : Text label refactored in test.
aliasgar4558 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Please move these declarations above (line 3637) and use these variables in the pumpWidget body (lines 3653 & 3658).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Updated now.