Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 : FIX : Long labels overflowing in extended navigation rail. #145474

Merged
merged 58 commits into from May 8, 2024
Merged

🐛 : FIX : Long labels overflowing in extended navigation rail. #145474

merged 58 commits into from May 8, 2024
+61 −8

Conversation

aliasgar4558
Copy link
Contributor

@aliasgar4558 aliasgar4558 commented Mar 20, 2024 •
edited by bleroux

It has been observed that while in extended navigation rail, if longer labels are given the it is overflowing. Problem identified in "NavigationRail" widget only in case of extended version of it. This PR includes the fix for the same.

Fixes #110901.

NO breaking changes.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 20, 2024
@aliasgar4558 aliasgar4558 changed the base branch from master to main March 21, 2024 16:36
@aliasgar4558 aliasgar4558 reopened this Mar 26, 2024
@aliasgar4558
Copy link
Contributor Author

Closed by mistake, re-opened the PR.

@bleroux
Copy link
Contributor

bleroux commented May 7, 2024

@aliasgar4558 Sorry for the burden, you will have to rebase this PR on the master branch (you can close this one and file a new one if it is easier for you), main branch can not be targeted for PRs on flutter/flutter (the bots won't work with it).

FYI, for the other Flutter repos, main branch is ok, especially for flutter/engine but this is not the case for flutter/flutter.

@aliasgar4558
Copy link
Contributor Author

@bleroux - Thanks for the suggestions. It seems good to have those in the PR so will add that.

Also, Just to confirm - instead of main branch, we have to target this PR to master branch. Is that correct?

@bleroux
Copy link
Contributor

bleroux commented May 7, 2024

Also, Just to confirm - instead of main branch, we have to target this PR to master branch. Is that correct?

Yes, this is required in flutter/flutter. Sorry for the burden.

@aliasgar4558
Copy link
Contributor Author

@bleroux - Not problem at all. I am here to learn and contribute & you guys are helping me. So all good. Will do the needful and update PR.

@aliasgar4558 aliasgar4558 changed the base branch from main to master May 7, 2024 15:05
@aliasgar4558
Copy link
Contributor Author

@bleroux - I have updated test as per your suggested changes & now PR is targeting to master branch. Please review once you get some time.

bleroux
bleroux reviewed May 8, 2024
View reviewed changes
packages/flutter/test/material/navigation_rail_test.dart Outdated
Comment on lines 3674 to 3675
const String normalLabel = 'Abc';
const String longLabel = 'Very long bookmark text for navigation destination';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please move these declarations above (line 3637) and use these variables in the pumpWidget body (lines 3653 & 3658).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Updated now.

bleroux
bleroux approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution 🙏

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2024
@auto-submit auto-submit bot merged commit 4d6c00c into flutter:master May 8, 2024
73 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
4d6c00cc2 🐛 : FIX : Long labels overflowing in extended navigation ra…
f9ac26a 
…il. (flutter/flutter#145474)
@aliasgar4558
Copy link
Contributor Author

@dkwingsmt @bleroux - Thank you so much for your valuable insights for this PR. Really Appreciate it 😊

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
4d6c00cc2 🐛 : FIX : Long labels overflowing in extended navigation ra…
1e98757 
…il. (flutter/flutter#145474)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
4d6c00cc2 🐛 : FIX : Long labels overflowing in extended navigation ra…
5bb70d2 
…il. (flutter/flutter#145474)
@aliasgar4558 aliasgar4558 deleted the Code/Fix/label_overflow_in_extended_rail branch May 8, 2024 17:51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
@engine-flutter-autoroll
4d6c00cc2 🐛 : FIX : Long labels overflowing in extended navigation ra…
5d45977 
…il. (flutter/flutter#145474)
@dkwingsmt
Copy link
Contributor

Thank YOU for the contribution, and continuously addressing our comments!

@Piinks Piinks mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[adaptive_scaffold] NavigationDestination with icon + label overflows within navigation rail.
3 participants
@aliasgar4558 @dkwingsmt @bleroux