Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 : FIX : Long labels overflowing in extended navigation rail. #145474

Merged
merged 58 commits into from
May 8, 2024
Merged

🐛 : FIX : Long labels overflowing in extended navigation rail. #145474

merged 58 commits into from
May 8, 2024

Commits on Mar 20, 2024

  1. 🐛 : FIX : Long labels overflowing in extended navigation rail.

    @aliasgar4558
    aliasgar4558 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    fa4fca9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende… 

    …d_rail
    @aliasgar4558
    aliasgar4558 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1156c28 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    156694f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b728a46 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    da1d802 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b223d7e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    0f5b16a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    a376245 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    71978c2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    8a6d5d9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    aab3962 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    cc17e01 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    9ec4d7c View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    058dbb9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    17d4f91 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4c523e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    98a639a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f31daa8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a7e9735 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4725df8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e581bf9 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    251effd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7f4e863 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    515e110 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c65a9e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    0c342f7 View commit details
    Browse the repository at this point in the history

  2. 🎨 : Expanded replaced with "Flexible" to prevent overflow bounds. 

    ✅ : Breaking test cases updated.
    @aliasgar4558
    aliasgar4558 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2b34357 View commit details
    Browse the repository at this point in the history

  3. ✅ : Tightly coupled test case added.

    @aliasgar4558
    aliasgar4558 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c997a9b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a503388 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b8eeb27 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b74bf0d View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    861a377 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail 

    # Conflicts:
#	packages/flutter/lib/src/material/navigation_rail.dart
    @aliasgar4558
    aliasgar4558 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    240e99b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    a461ec6 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    50e261d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7d91e6b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    affc19b View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0955bb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bb3f8af View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0963364 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende… 

    …d_rail
    @aliasgar4558
    aliasgar4558 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    bb277b2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    abbf860 View commit details
    Browse the repository at this point in the history

  3. ✅ : Test case updated to determine the Nav. destination's height on w… 

    …idth change.
    @aliasgar4558
    aliasgar4558 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    0b5803f View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0e2381e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    11a2bce View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
    @aliasgar4558 @dkwingsmt
    aliasgar4558 and dkwingsmt committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a95116a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Update packages/flutter/test/material/navigation_rail_test.dart 

    Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
    @aliasgar4558 @dkwingsmt
    aliasgar4558 and dkwingsmt committed May 7, 2024
    Configuration menu
    Copy the full SHA
    833c979 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b92a815 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    db66288 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f784461 View commit details
    Browse the repository at this point in the history

  5. 💡 : PR comments & suggestions resolved for test case.

    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9f88074 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende… 

    …d_rail
    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1398cfe View commit details
    Browse the repository at this point in the history

  7. Merge branch 'Code/Fix/label_overflow_in_extended_rail' into Code/Fix… 

    …/label_overflow_in_extended_rail2
    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0082afe View commit details
    Browse the repository at this point in the history

  8. Merge branch 'flutter:master' into Code/Fix/label_overflow_in_extende… 

    …d_rail
    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d6458a8 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    908ee43 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f0bd607 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Code/Fix/label_overflow_in_extended_rail

    @aliasgar4558
    aliasgar4558 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ecf9a3f View commit details
    Browse the repository at this point in the history

  3. ♻️ : Text label refactored in test.

    @aliasgar4558
    aliasgar4558 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1205c75 View commit details
    Browse the repository at this point in the history