Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headers-support-utf8 #1210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

headers-support-utf8 #1210

wants to merge 1 commit into from

Conversation

Doc999tor
Copy link

@Doc999tor Doc999tor commented May 23, 2023

This PR adds support of busboy's defParamCharset option for supporting UTF8 characters in request headers such as filename
Default: 'latin1' for backward compatibility
Not required

Resolves #1104, #1194

Example of usage:

multer({
	storage,
	defParamCharset: 'utf8',
})

@Doc999tor
Copy link
Author

TypeScript definitions update - DefinitelyTyped/DefinitelyTyped#65578

@starnayuta
Copy link

@Doc999tor
Thanks for the PR.
I am also having trouble with UTF-8 file names.

The default for defParamCharset should be UTF-8.
Here is the parsing of the filenames for each version that I recognize

1.4.4 and below: UTF-8
1.4.5-lts.1: Latin-1

If it takes semantic versioning, it should be UTF-8, the same as 1.4.4.

@LinusU wrote a comment that might be relevant. What do you think?
#1104 (comment)

At any rate, I hope it will be released as soon as possible.
Thank you.

@Doc999tor
Copy link
Author

@starnayuta
I understand that but the v1.4.5 was marked as lts, so I don't believe it will be changed as part of 1.4.5; only as a new version, until it will become lts as well

@Doc999tor
Copy link
Author

@LinusU Are there any blockers for merging this PR? Can we merge it?

@Doc999tor
Copy link
Author

@UlisesGascon, maybe you could assist with this PR?

@threshold862543
Copy link

Would be nice to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with UTF-8 characters in filename
3 participants