2720 - Definitive Global/Country file fix, support for UTF-8 filenames #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfontanarosa
changed the title
sorja
previously approved these changes
Jun 7, 2023
|
wrong video? |
|
There is a PR for Multer that solves the issue - expressjs/multer#1210 |
minotogna
reviewed
Jun 8, 2023
src/test/migrations/steps/20230607170529-step-primary-key-for-table-file.ts
Outdated
Show resolved
Hide resolved
sorja
approved these changes
Jun 8, 2023
minotogna
approved these changes
Jun 8, 2023
|
@minotogna Great to know it is fixed, plz move this file(Oportunidades de restauracion en Guatemala.pdf) to the Repository of Guatemala Remove other two testing files: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2720
upload: multer, due to busboy dependency, doesn't support utf-8 filenames by default. there is a workaround to fix it: expressjs/multer#1104
download: nodejs doesn't support utf-8 on response header content-disposition: https://stackoverflow.com/questions/23895924/expressjs-download-filename-utf-8
primary key: pgadmin doesn't allow me to change file table on the fly because it hadn't a primary key. this problem can occurs with others sql clients. I just added a primary key as in the other tables (col, row)
Registrazione.schermo.2023-06-07.alle.16.51.59.mov