expressjs_multer/support-for-unicode-headers

[Doc999tor]

ExpressJS Multer multer.Options update for defParamCharset field
Supports unicode in requests headers such as filename

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <PR>

[typescript-bot]

@Doc999tor Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• multer — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 65578,
  "author": "Doc999tor",
  "headCommitOid": "dad9adf5ebe5a83f2fc5f1a4a77b342dc81b1da7",
  "mergeBaseOid": "bb0952895635ce58e51bce7f6c9fb2096ea006c6",
  "lastPushDate": "2023-05-23T23:09:37.000Z",
  "lastActivityDate": "2023-06-12T18:19:28.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "multer",
      "kind": "edit",
      "files": [
        {
          "path": "types/multer/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jt000",
        "vilic",
        "DavidBR-SW",
        "mxl",
        "hyunseob",
        "PierreTchuente",
        "thrymgjol",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "sheetalkamat",
      "date": "2023-06-12T18:19:28.000Z"
    }
  ],
  "mainBotCommentID": 1560242481,
  "ciResult": "pass"
}

[typescript-bot]

Hey @Doc999tor,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @jt000 @vilic @DavidBR-SW @mxl @HyunSeob @PierreTchuente @thrymgjol @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@Doc999tor The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[peterblazejewicz]

Is the expressjs/multer#1210 PR a predecessor to this PR?

[Doc999tor]

@peterblazejewicz - the opposite: expressjs/multer#1210 relies on this PR for correct Typescript compiling

[peterblazejewicz]

@peterblazejewicz - the opposite: expressjs/multer#1210 relies on this PR for correct Typescript compiling

oh, thanks! I believe that's not a path here. I believe no changes are published from DT repo, until backed by native JS code first (we want to avoid people using DT definition enforcing adding a code which does not exists at runtime). Why this opposite direction?
IMO once native JS module get's published this one should be merged as no-brainer.

[typescript-bot]

Re-ping @jt000, @vilic, @DavidBR-SW, @mxl, @HyunSeob, @PierreTchuente, @thrymgjol, @peterblazejewicz:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[peterblazejewicz]

LGTM!

unreleased

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @Doc999tor.

(Ping @jt000, @vilic, @DavidBR-SW, @mxl, @HyunSeob, @PierreTchuente, @thrymgjol, @peterblazejewicz.)

[sheetalkamat]

Please mark this as draft or close it and reopen when the corresponding PR is merged. Thanks

[typescript-bot]

@Doc999tor One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@Doc999tor I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jul 12th (in a week) if the issues aren't addressed.

[typescript-bot]

@Doc999tor To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!