Existing experiment disabled, the new Settings experiment activated #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atest implementation of subscription adjusted based on the old Settings view.
github-actions
bot
added
the
bot: not in app board
|
@afterxleep, could you please smoke test the Privacy Pro onboarding flow? I have noticed there was a change since I merged the new Settings. I matched the code with the old Settings in this PR. |
brindy
removed
the
bot: not in app board
|
looks on @tomasstrba. |
samsymons
added a commit
that referenced
this pull request
May 1, 2024
* main: Release 7.118.0-1 (#2812) [Release PR] Update VPN metadata reporter (#2808) fix address bar weirdness (#2810) Fix RMF button styling for "big_two_action" format (#2811) Existing experiment disabled, the new Settings experiment activated (#2801) Create Asana Subtask on PR requested (#2803) Remove ATB from default params (#2430) Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779) Disable the feedback send button when there’s no text (#2800)
samsymons
added a commit
that referenced
this pull request
May 1, 2024
# By Sam Symons (3) and others # Via Chris Brind (1) and GitHub (1) * main: Release 7.118.0-1 (#2812) [Release PR] Update VPN metadata reporter (#2808) fix address bar weirdness (#2810) Fix RMF button styling for "big_two_action" format (#2811) Existing experiment disabled, the new Settings experiment activated (#2801) Create Asana Subtask on PR requested (#2803) Remove ATB from default params (#2430) Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206933032583646/f
CC:
Description:
New Settings experiment
Steps to test this PR:
PixelExperimentLogicallocates user to a cohort based on the random numbernewSettingsand make sure the new Settings view is presented to userDevice Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template