Existing experiment disabled, the new Settings experiment activated (#…

…2801)
duckduckgo · May 1, 2024 · 985efac · 985efac
1 parent dbeab68
commit 985efac
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/Core/DefaultVariantManager.swift b/Core/DefaultVariantManager.swift
@@ -62,9 +62,8 @@ public struct VariantIOS: Variant {
         VariantIOS(name: "sc", weight: doNotAllocate, isIncluded: When.always, features: []),
         VariantIOS(name: "sd", weight: doNotAllocate, isIncluded: When.always, features: []),
         VariantIOS(name: "se", weight: doNotAllocate, isIncluded: When.always, features: []),
-
-        VariantIOS(name: "mc", weight: 1, isIncluded: When.inEnglish, features: [.newSuggestionLogic]),
-        VariantIOS(name: "md", weight: 1, isIncluded: When.inEnglish, features: [.history]),
+        VariantIOS(name: "mc", weight: doNotAllocate, isIncluded: When.inEnglish, features: [.newSuggestionLogic]),
+        VariantIOS(name: "md", weight: doNotAllocate, isIncluded: When.inEnglish, features: [.history]),
 
         returningUser
     ]

diff --git a/Core/PixelExperiment.swift b/Core/PixelExperiment.swift
@@ -51,7 +51,6 @@ public enum PixelExperiment: String, CaseIterable {
 
     /// Enables this experiment for new users when called from the new installation path.
     public static func install() {
-        // Disable the experiment until all other experiments are finished
         logic.install()
     }
 
@@ -101,12 +100,10 @@ final internal class PixelExperimentLogic {
 
         // Allocate user to a cohort based on the random number
         let cohort: PixelExperiment
-        if randomNumber < 5 {
+        if randomNumber < 50 {
             cohort = .control
-        } else if randomNumber < 10 {
-            cohort = .newSettings
         } else {
-            cohort = .noVariant
+            cohort = .newSettings
         }
 
         // Store and use the selected cohort

diff --git a/DuckDuckGo/AppDelegate.swift b/DuckDuckGo/AppDelegate.swift
@@ -217,8 +217,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             DaxDialogs.shared.primeForUse()
         }
 
-        // Experiment installation will be uncommented once we decide to run the experiment
-//        PixelExperiment.install()
+        PixelExperiment.install()
 
         // MARK: Sync initialisation
 

diff --git a/DuckDuckGo/SettingsRootView.swift b/DuckDuckGo/SettingsRootView.swift
@@ -85,8 +85,11 @@ struct SettingsRootView: View {
                     }
                 })
 
-        .onReceive(viewModel.$deepLinkTarget, perform: { link in
-            guard let link else { return }
+        .onReceive(viewModel.$deepLinkTarget.removeDuplicates(), perform: { link in
+            guard let link, link != self.deepLinkTarget else {
+                return
+            }
+
             self.deepLinkTarget = link
 
             switch link.type {