Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing experiment disabled, the new Settings experiment activated #2801

Merged
merged 3 commits into from
May 1, 2024
Merged

Existing experiment disabled, the new Settings experiment activated #2801

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f61d99c
Existing experiment disabled, the Settings expriment activated, the l…
tomasstrba Apr 29, 2024
d3fa375
Extra comment deleted
tomasstrba Apr 29, 2024
a454eb3
50/50 allocation
tomasstrba May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions Core/DefaultVariantManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,8 @@ public struct VariantIOS: Variant {
VariantIOS(name: "sc", weight: doNotAllocate, isIncluded: When.always, features: []),
VariantIOS(name: "sd", weight: doNotAllocate, isIncluded: When.always, features: []),
VariantIOS(name: "se", weight: doNotAllocate, isIncluded: When.always, features: []),

VariantIOS(name: "mc", weight: 1, isIncluded: When.inEnglish, features: [.newSuggestionLogic]),
VariantIOS(name: "md", weight: 1, isIncluded: When.inEnglish, features: [.history]),
VariantIOS(name: "mc", weight: doNotAllocate, isIncluded: When.inEnglish, features: [.newSuggestionLogic]),
VariantIOS(name: "md", weight: doNotAllocate, isIncluded: When.inEnglish, features: [.history]),

returningUser
]
Expand Down
1 change: 0 additions & 1 deletion Core/PixelExperiment.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public enum PixelExperiment: String, CaseIterable {

/// Enables this experiment for new users when called from the new installation path.
public static func install() {
// Disable the experiment until all other experiments are finished
logic.install()
}

Expand Down
3 changes: 1 addition & 2 deletions DuckDuckGo/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
DaxDialogs.shared.primeForUse()
}

// Experiment installation will be uncommented once we decide to run the experiment
// PixelExperiment.install()
PixelExperiment.install()

// MARK: Sync initialisation

Expand Down
7 changes: 5 additions & 2 deletions DuckDuckGo/SettingsRootView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,11 @@ struct SettingsRootView: View {
}
})

.onReceive(viewModel.$deepLinkTarget, perform: { link in
guard let link else { return }
.onReceive(viewModel.$deepLinkTarget.removeDuplicates(), perform: { link in
guard let link, link != self.deepLinkTarget else {
return
}

self.deepLinkTarget = link

switch link.type {
Expand Down