Remove BIP70 payment requests #3466
Conversation
patricklodder
force-pushed
the
1.15.0-remove-bip70
branch
2 times, most recently
from
279baa3
to
4a352ad
Compare
|
Found 3 issues with remaining OpenSSL/proxy includes while cleaning up depends. Added these separately. |
patricklodder
force-pushed
the
1.15.0-remove-bip70
branch
from
b296bdc
to
09cf8aa
Compare
Completely removes BIP70 support from Dogecoin Qt code. Also removes protobuf-compatibility tests as these rely on paymentserverplus code and any TLS related configuration.
Protobuf was only needed for BIP70 payment requests
patricklodder
force-pushed
the
1.15.0-remove-bip70
branch
from
09cf8aa
to
7968ab5
Compare
|
Squashed the additional commits. The pre-squash version of this PR can be found at I think this is as ready for review as it will get, assuming 3 PRs:
|
| paymentServer = new PaymentServer(this, true, GetBoolArg("-enable-bip70", false)); | ||
| paymentServer = new PaymentServer(this, true); |
There was a problem hiding this comment.
Not for now, but we'll want to remember we once supported this flag when we move to 1.21 or reimplement/cherry-pick the code that checks for unsupported CLI arguments.
There was a problem hiding this comment.
Added your note to #1313
| if (rcp.label.length() > CHARACTERS_DISPLAY_LIMIT_IN_LABEL) | ||
| { | ||
| recipientElement = tr("%1 to %2").arg(amount, address); | ||
| displayedLabel = displayedLabel.left(CHARACTERS_DISPLAY_LIMIT_IN_LABEL).append("..."); // limit the amount of characters displayed in label | ||
| } | ||
| recipientElement = tr("%1 to %2").arg(amount, GUIUtil::HtmlEscape(displayedLabel)); | ||
| recipientElement.append(QString(" (%1)").arg(address)); |
There was a problem hiding this comment.
Is there a chance the length of the recipient element will exceed the display limit after the substitution?
There was a problem hiding this comment.
We lowered the limit to fit the .... Note that this is move-only (indentation) for this PR
|
All tests pass on x86-64. Conditional approval, provided an answer to the question about label length and the removal of |
Thanks! Removed. |
Removes:
bswap_16,bswap_32andbswap_64This does not (yet) change:
dependssystemBesides CI targets, I've tested this extensively on macOS and some Ubuntu Jammy with Qt 5.12.
Should get extensive review, and it would be good to wait a little with moving forward with this in case we get any feedback re: BIP70 removal from the 1.14.7 release.