New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends: remove bip70-related artifacts from depends #3474
base: 1.15.0-dev
Are you sure you want to change the base?
depends: remove bip70-related artifacts from depends #3474
Conversation
Completely removes BIP70 support from Dogecoin Qt code. Also removes protobuf-compatibility tests as these rely on paymentserverplus code.
Protobuf was only needed for BIP70 payment requests
👍 to this approach. Looking for other instances of All tests pass on x86-64 Linux. |
This comment was marked as outdated.
This comment was marked as outdated.
Correcting my previous plan upon further inspection:
|
I'm 100% okay with delaying/deferring both, as neither seems intrinsic to our goal here. |
Built on top of #3466 to remove protobuf from depends, and openssl as a requirement from Qt.
I can add this to the other PR but I thought that maybe it's more useful for review to keep them separate: one to remove code, and another to cleanup the build. Let me know what is useful please.