Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: remove bip70-related artifacts from depends #3474

Draft
wants to merge 8 commits into
base: 1.15.0-dev
Choose a base branch
from

Conversation

patricklodder
Copy link
Member

Built on top of #3466 to remove protobuf from depends, and openssl as a requirement from Qt.

I can add this to the other PR but I thought that maybe it's more useful for review to keep them separate: one to remove code, and another to cleanup the build. Let me know what is useful please.

@chromatic
Copy link
Member

👍 to this approach.

Looking for other instances of protobuf I see a mention in src/compat/byteswap.h that's probably harmless and a mention in contrib/rpm/bitcoin.spec. I didn't look deeply for other openssl mentions, as the scope of that is beyond Qt, and because we include attribution in the locale files.

All tests pass on x86-64 Linux.

@patricklodder

This comment was marked as outdated.

@patricklodder
Copy link
Member Author

Correcting my previous plan upon further inspection:

  • src/compat/byteswap.h the only thing we could change there is the comment. Code must remained unchanged as it is safer the way it is now than it is without the #if !defined(bswap_16)
  • contrib/rpm/bitcoin.spec is (apparently) completely unmaintained. It needs a ton of work to be usable, so if we want that, I suggest we pick that up in a separate effort.

@chromatic
Copy link
Member

I'm 100% okay with delaying/deferring both, as neither seems intrinsic to our goal here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants