Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/core/eval: add testcase for https://github.com/cue-lang/cue/issues/2566 issue #2588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bozaro
Copy link
Contributor

@bozaro bozaro commented Sep 11, 2023

Signed-off-by: Artem V. Navrotskiy <bozaro@yandex.ru>
Signed-off-by: Artem V. Navrotskiy <bozaro@yandex.ru>
Signed-off-by: Artem V. Navrotskiy <bozaro@yandex.ru>
@mvdan
Copy link
Member

mvdan commented Oct 25, 2023

Thanks for these PRs! You might want to use Gerrit instead of GitHub for your contributions, because that's the source of truth for git and where we do the vast majority of our code reviews, and on top of that you can "chain" your CLs (commits) via a branch. That ends up being a lot nicer to review and merge than with GitHub PRs, where you have to either keep one PR with many commits, or awkwardly "stack" your PRs on top of one another by accumulating commits.

For example, see this stack of CLs by Roger which we reviewed and merged recently: https://review.gerrithub.io/c/cue-lang/cue/+/1170886

https://github.com/cue-lang/cue/blob/master/CONTRIBUTING.md should have more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants