cue/stats: add metric for builtin calls #2587
Conversation
Signed-off-by: Artem V. Navrotskiy <bozaro@yandex.ru>
Signed-off-by: Artem V. Navrotskiy <bozaro@yandex.ru>
bozaro
force-pushed
the
builtns-stat
branch
from
0d2f198
to
2a5d0a9
Compare
There was a problem hiding this comment.
I'll run this past Marcel to see if he agrees that having builtin call counters in the stats is useful. I think it can be helpful when debugging or testing, like in your test in #2588, so I don't oppose adding this stat.
We might want this metric counter in a slightly different form, like Calls. Once we add function signatures to the language per #2007, perhaps implemented by wasm, then those could be counted the same way. I don't think splitting builtins calls from other function calls would be necessary.
| @@ -1481,6 +1481,7 @@ func (x *CallExpr) evaluate(c *OpContext, state vertexStatus) Value { | |||
| if b.IsValidator(len(args)) { | |||
| return &BuiltinValidator{x, b, args} | |||
| } | |||
| c.stats.Builtins++ | |||
There was a problem hiding this comment.
note that BuiltinValidator ends up calling the call method as well; you should probably increment the counter inside that method to capture all builtin calls being performed.
Add
Builtinsmetric to allow tests for issues like #2566