Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR (only the last commit is important):
This change breaks backward compatibility, but I couldn't think of anything better.
I try explain this workaround by example
cue/testdata/eval/let_funcs.txtar
:In original code:
let env_context
callstrings.HasPrefix
at the first time and create finazlied*adt.Vertex
(vertex_1
). This*adt.Vertex
also contains*adt.CallExpr
somewhere in conjuncts;e1: env_context
create new*adt.Vertex
(vertex_2
). On creatingvertex_2
executedn.addVertexConjuncts(v, arc, false)
withvertex_1
asarc
;addVertexConjuncts
internally add all conjuncts fromvertex_1
tovertex_2
;vertex_2
finalization reevaluates*adt.CallExpr
from added conjuncts.After this workaround
vertex_1
became data and lost conjuncts with*adt.CallExpr
node.