@one_hot attribute
#2042
Merged
@one_hot attribute
#2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachitnigam
reviewed
May 17, 2024
calyx-frontend/src/attributes.rs
Outdated
| /// keys: A, D | ||
| /// Then self gets: A->15 B->5. (D is ignored since it's not inpresent in other | ||
| /// and C is ignored since it's not keys.) | ||
| pub fn mirror_attributes<A>(&mut self, other: Self, keys: Vec<A>) |
There was a problem hiding this comment.
Maybe we can call this copy_to instead?
There was a problem hiding this comment.
I changed to copy_from since technically we are copying attributes from other to self.
rachitnigam
reviewed
May 17, 2024
| ir::Control::enable(init_group), | ||
| while_loop, | ||
| ]); | ||
| let while_seq = ir::Control::Seq(ir::Seq { |
There was a problem hiding this comment.
Is there an ir::Control::seq method to construct this nest of Seq { Seq { ... } } ?
There was a problem hiding this comment.
There is, but it gives the seq ir::Attributes::default().
rachitnigam
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for a
@one_hotattribute that can be attached tostaticcontrol and tells the compiler to construct a one-hot FSM.(Not a guarantee, since promotion and other optimizations that rewrite control could subsume the attribute).
Also add a pass called
static-fsm-optswhich attaches the@one_hotattribute, based on a "cutoff", i.e., if the number of cycles is less than the cutoff, then do one hot encoding, but switch to binary encoding if cycle count is greater than cutoff.I can imagine this pass being responsible for attaching all sorts of attributes as we implement more FSM optimizations.(Also did some minor changes to optimization passes so that we copy over the
@one_hotattribute).