gen_msb: Tidying using modern eDSL
#2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahanxie353
pushed a commit
to jiahanxie353/calyx
that referenced
this pull request
May 29, 2024
* Tidy some cell generation * Take a port by handle * Use new lsh_use * Use lsh_use more. * More tidying using builder helpers * No names for registers * Tidy imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the work of #2034 and #2036, this PR does some tidying on the single file
gen_msb.py. The diff file will be very pleasing, as this file was really ripe for a little cleanup using modern eDSL features. We now pass as few strings as we can, infer as many widths as we can, and generally leave all group-creation to the builder library.Closes #1673