Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: pass verbose through to cmake based makefiles #29960

Merged
merged 1 commit into from May 6, 2024

Conversation

m3dwards
Copy link
Contributor

@m3dwards m3dwards commented Apr 25, 2024

While testing #29708 I was not able to enable verbose output to check which flags were being given to the compiler.

With this PR, running depends with V=1 will enable verbose output from makefiles generated by cmake.

How to test:

make -C depends libnatpmp V=1

When running depends with V=1 this will now enable verbose output from makefiles generated by cmake.
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 25, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, fanquake
Concept ACK alfonsoromanz, theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29962 (RFC: depends: add release type to CMake builds by theuni)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake
Copy link
Member

Concept ACK

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7c69baf. Tested using the folowing command:

make -C depends native_capnp_built MULTIPROCESS=1 V=1

@alfonsoromanz
Copy link
Contributor

Concept ACK

@theuni
Copy link
Member

theuni commented Apr 25, 2024

Concept ACK. I just ran into this locally. I solved it using V=1 VERBOSE=1, but this makes sense too.

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 0e2e7d1
(master)
commit deda98e
(master and this pull)
SHA256SUMS.part cb61aee9f80ec1ba... 282e9656781e74a4...
*-aarch64-linux-gnu-debug.tar.gz aee07f71c47fe4ce... ccdd5f7e47b97d02...
*-aarch64-linux-gnu.tar.gz ba2365bd11aa0d2e... 117cddbc843a018d...
*-arm-linux-gnueabihf-debug.tar.gz 5b8e0c3177a93ff7... dfc4e820992cefae...
*-arm-linux-gnueabihf.tar.gz 80dd4d3fa9886900... 917321b8590b705e...
*-arm64-apple-darwin-unsigned.tar.gz a05f1e80bb8368cf... aa726a78c0fa8c76...
*-arm64-apple-darwin-unsigned.zip d7fddc2fd63564b5... 65f0651e4fd98030...
*-arm64-apple-darwin.tar.gz 9cf49289529c199a... a4a55c7282396678...
*-powerpc64-linux-gnu-debug.tar.gz 1ff0e9a500866b2f... fba27becd65ea815...
*-powerpc64-linux-gnu.tar.gz 0c57fe0ca2060225... f11dc31b379c36ba...
*-riscv64-linux-gnu-debug.tar.gz f297c7785b048f1e... eeb5c2f91de78d60...
*-riscv64-linux-gnu.tar.gz ba8df476a4f5795d... 759a78fd93c9db17...
*-x86_64-apple-darwin-unsigned.tar.gz f050edb765f1e320... 52adb8622d5af022...
*-x86_64-apple-darwin-unsigned.zip 37262b66a3c5729c... c010af8b9e5e3b2e...
*-x86_64-apple-darwin.tar.gz 9a234f1b809e0f06... 3c8e03397f1d39f0...
*-x86_64-linux-gnu-debug.tar.gz 2934441057abec67... 0772ee06f2351958...
*-x86_64-linux-gnu.tar.gz a6a70305a97536a8... eabda4adc7456089...
*.tar.gz 380e07ef0f352d9b... 3b91e23e5c5728c4...
guix_build.log 3d2cadabdeb0586f... 37c3f193a47f42b1...
guix_build.log.diff a51541c09914dfc5...

@m3dwards
Copy link
Contributor Author

I have tried to look for an alternative variable that will enable verbose output regardless of build system but I couldn't find one. I thought this looked promising https://cmake.org/cmake/help/latest/envvar/VERBOSE.html but it didn't work for me.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7c69baf

@DrahtBot DrahtBot requested a review from theuni May 6, 2024 01:46
@fanquake fanquake merged commit 00ac1b9 into bitcoin:master May 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants