New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: depends: add release type to CMake builds #29962
base: master
Are you sure you want to change the base?
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Ping @hebasto |
The defaults for the "Makefile" generator are:
That differs from our flags, which are And CMake can change its defaults at any time ( However, it would be nice to be explicit about the used build type, for example, |
Right, but a few more things to consider: An upstream build could be following the docs and doing something like: # Works correctly for both single and multi-config generators
target_compile_definitions(exe1 PRIVATE
$<$<CONFIG:Debug>:DEBUG_BUILD>
) In this case, we wouldn't currently pick up the extra debug opts. The other thing to consider that is that we could be using Note that I don't necessarily believe these arguments and don't feel strongly either way, I just wanted to raise the discussion. |
i think Edit: Oh, to not forget, debug metadata is also useful to figure out the details of differences between guix-built binaries, like where do they exactly come from. This is what i tend to most often use it for. |
🐙 This pull request conflicts with the target branch and needs rebase. |
RFC because I'm not sure if this is the right thing to do in combination with our CFLAGS/CXXFLAGS/etc env overrides.
I believe it was suggested by @laanwj at some point.