depends: build zeromq with CMake

[fanquake]

Based on #30078.

This picks up a change, which is a switch to building zeromq with CMake. It includes a patch with a couple changes I've upstreamed:

• build: fix mkdtemp check on macOS zeromq/libzmq#4668
• cmake: don't use builtin sha1 if not using ws zeromq/libzmq#4670

and another Windows-related change:

• Do not use _MSC_VER if windows zeromq/libzmq#4678

I also noticed the CMake Windows version autodetction was broken with mingw-w64 (zeromq/libzmq#4669), so we set the version explicitly.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

[hebasto]

Concept ACK.

[hebasto]

This picks up a change, which is a switch to building zeromq with CMake.

From zeromq/libzmq#4667 (comment):

Please note that CMake-generated libzmq.pc file is also broken as its "Libs.private" section contains only -lstdc++ when cross-compiling for Windows.

[fanquake]

From zeromq/libzmq#4667 (comment):

Can you elaborate / suggest something concrete? As far as I can see, the cross-compiling build of Windows for this branch currently works fine, we already link again -lws2_32 from our own build (so that shouldn't cause build failures), and we currently patch the -lstdc++ out of Libs.private, because as far as we are concerned, it's a bug.

[fanquake]

Given both changes have landed, I've reordered the commits, and undrafted. Will followup with the Windows issues.

[fanquake]

Will followup with the Windows issues.

IPC build issue should be fixed in zeromq/libzmq#4672

[fanquake]

IPC build issue should be fixed in zeromq/libzmq#4672

This was resolved using a different change. Have pulled in that patch, rebased and updated the PR description.

[hebasto]

I've tested 796a271 on Ubuntu 23.10 using a patch from #29960.

There are a few differences between Autotools and CMake builds:

1. In CMake, the resulted archive lacks object files from the following sources:

gssapi_client.cpp
gssapi_mechanism_base.cpp
gssapi_server.cpp
vmci_address.cpp
vmci_connecter.cpp
vmci_listener.cpp
vmci.cpp

2. CMake build is effectively compiled with -O3 flag.

3. CMake adds -DZMQ_CUSTOM_PLATFORM_HPP.

[DrahtBot]

/ci_container_base/depends/work/build/x86_64-w64-mingw32/zeromq/4.3.5-fa67b8336a3/src/ipc_listener.cpp:22:2: error: #error On Windows, IPC does not work with POLLER=select, use POLLER=epoll instead, or disable IPC transport
   22 | #error On Windows, IPC does not work with POLLER=select, use POLLER=epoll instead, or disable IPC transport
      |  ^~~~~

[fanquake]

Fixed the Windows build error, but drafted while based on #30078.