Migrate to yarn for installing dependencies #8762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 20, 2021 09:50
jroebu14
force-pushed
the
migrate-to-yarn
branch
from
067c82a
to
3bf9f74
Compare
jroebu14
added
the
cross-team
jroebu14
changed the title
6 tasks
andrewscfc
reviewed
Feb 3, 2021
ryanmccombe
approved these changes
Feb 3, 2021
added 5 commits
February 10, 2021 16:02
replace npm scripts commands with yarn
jroebu14
requested review from
chris-hinds,
craigkj,
jamesdonoh,
j-pendlebury and
sareh
as code owners
andrewscfc
reviewed
Feb 17, 2021
package.json
Outdated
| @@ -111,10 +111,10 @@ | |||
| "@bbc/psammead-useful-links": "3.0.14", | |||
| "@bbc/psammead-visually-hidden-text": "2.0.3", | |||
| "@bbc/web-vitals": "1.0.2", | |||
| "@emotion/cache": "11.1.3", | |||
| "@emotion/react": "11.1.4", | |||
| "@emotion/cache": "11.0.0", | |||
There was a problem hiding this comment.
Shouldn't this be at the latest version? Probably should test this with the latest version
There was a problem hiding this comment.
I must have missed this when upgrading the others 🙁
RichardPK
reviewed
Feb 17, 2021
| @@ -0,0 +1,19 @@ | |||
| const ensureYarn = () => { | |||
| // If npm is being run, print a message and cause 'npm install' to fail. | |||
jroebu14
force-pushed
the
migrate-to-yarn
branch
from
d52e82f
to
ad1be8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8761
Overall change:
Switch to using Yarn for installing node modules.
Simorgh infrastructure changes https://github.com/bbc/simorgh-infrastructure/pull/1329
Code changes:
npm ciwithyarn install --frozen-lockfilein github actions directory.github/workflows/package-lock.jsonand addsyarn.lockincluding any references in code--no-saveoption when installing and they are very opinionated on why. This is a problem in one of our GH actions where we install puppeteer. I've changed the action toyarn add puppeteerwhich by default saves to the lock file then I remove the package after running the puppeteer tests withyarn remove puppeteer. Not 100% sure if we need to do this but I suppose it cleans up the puppeteer side-effects. This might actually be needed for caching node modules in GH actions for faster build times cache node_modules in github actions #8831 since a change to the lock file will bust the cache.updates snapshots for some reasoncross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)